Fixed: Shop logged out when submitting a form for 'Shop' objects (fixed in 8.2.1)

[Hammadk]

Version 7.3.0 introduced a bug where shops would be logged out when a controller received a shop hash param in an update. This effects version 7.3.0, 7.4.0, 8.0.0, 8.1.0, 8.2.0, and is fixed in 8.2.1.

Root cause

Consider the following case:

1. You have a model called Shop
2. In edit.html.erb, you use form_for @shop.

When someone clicks update, Rails will pass a shop hash to the controller and it looks like:
shop: { id: 123, title: 'foobar' }. When this hash is sent to LoginProtection:: login_again_if_different_shop , the shop is logged out.

This was fixed by only comparing the shop param when it was a String. This was fixed here.