default to the currency for thousand delimiter when unknown #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we're not able to make an educated guess on decimal vs thousand separator, default to using the decimal separator for the currency
de41e81
to
51e4081
Compare
TayKangSheng
approved these changes
Aug 16, 2024
|
sorry the rebase on v3 caused a bit of noise on this PR, please have another look 🙏 |
TayKangSheng
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The fuzzy parsing tries to guess the amount from a string. We can get a little more strict about the guesses we're making
What
When we're not able to guess if the delimiter is for thousands or decimals, defer to the currency decimal delimiter