Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-restart to supports DaemonSet #610

Closed
1 task done
vvuibert opened this issue Oct 31, 2019 · 2 comments · Fixed by #836
Closed
1 task done

kubernetes-restart to supports DaemonSet #610

vvuibert opened this issue Oct 31, 2019 · 2 comments · Fixed by #836

Comments

@vvuibert
Copy link

Feature request

  • If the maintainers agree with the feature as described here, I intend to submit a Pull Request myself.1

Proposal: patch kubernetes-restart to support DaemonSet since right now it only supports deployments. This would be useful to restart kafkabridge

1 This is the quickest way to get a new feature! We reserve the right to close feature requests, even ones we like, if the proposer does not intend to contribute to the feature and it doesn't fit in our current roadmap.

@dturn
Copy link
Contributor

dturn commented Oct 31, 2019

The feature sounds good to us. Adding a new flag to krane restart --daemonsets and a new kawrg to the task class https://github.com/Shopify/kubernetes-deploy/blob/50e7217d98cb98dc4f96fc4e64ecfc5809daa085/lib/krane/restart_task.rb#L57 would be our recommendation, but we're happy to discuss alternatives. We're also assuming that if you don't pass any flags and rely on annotations both DS & Deployments in a namespace will be restarted.

@vvuibert
Copy link
Author

@dturn I was able to automate restarting our deamonsets with https://github.com/Shopify/kafkabridge/pull/156/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants