Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ganj Nama Corrections #1253

Merged
merged 74 commits into from
Oct 17, 2019
Merged

Ganj Nama Corrections #1253

merged 74 commits into from
Oct 17, 2019

Conversation

bhajneet
Copy link
Member

@bhajneet bhajneet commented Oct 15, 2019

For correctors:

For developers:

  • Citation to use in git commits
    • Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, <PAGE>, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.
    • Where <PAGE> can be p. 43 or pp. 43-44. Most likely all of these will be found on a single page (e.g. "p. 43"). Use the Times New Roman physical page number found top-left/top-right in the photo of the PDF and not the page number of the PDF document itself.

Example git commit

fix(data/ganj-nama): update id 1IL! to match physical proof

Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 43, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #9001

Sanitization:

  • In-place bindi ˆ vs stand-alone bindi N
    • to yN
    • to YN
    • to oN
    • to ON
    • to IN
    • auˆ to auN
  • Confirm extended accents ü/¨
    • Ru to
    • RU to
  • Convert wN to W
  • HU to
  • Check ~ vs ` (Adhak)
  • Check nUM vs nUµ
  • Check R vs ® (In case of kR)
  • Check N vs ˆ
  • Check for any whitespace before vishraams
  • Check for apostrophes in gurmukhi and act accordingly (have a discussion if unsure, in this case since this is a transliteration we will want to keep hyphens and pair-bindi-akhars)
  • Remove any superscript numbers (i.e. ¹, ², ³, ⁴, ⁵, ...)
  • Missing data from varchar(255) import, use regex search : "(.{255})",

Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 138, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1252
@bhajneet bhajneet added Impacts All Affects nearly all or all end-users! Scope: Data/Ganj Nama Status: In Progress ○ Type Bug Regressions/production issues that do not function as intended. labels Oct 15, 2019
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 138, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1252
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 139, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1254
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1255
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1256
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1258
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1259
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1260
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1261
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1262
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1263
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1264
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1265
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1266
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1267
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1268
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1269
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1271
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1273
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1274
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1275
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1276
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1277
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 145, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1279
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1304
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1305
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1306
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1307
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1308
These lines occur at the start of each file. Only one (first one) had a different mistake. All 10 have been reviewed with the following proof.

Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, pp. 138-154, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1250, Related #1255 and #1256
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 154, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1310
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1311
NJ9Z is the only line that matches the proof with "Guru Gobind" instead of "Gur Gobind"

Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, pp. 154-161, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

See also #1310, #1311
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Also missed one instance related to commit f5ab161

Used regex this time to confirm that all instances match each other aside from line NJ9Z for the last 3 words.

Closes #1312, Related #1310, #1311
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1313
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1314
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1315
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 156, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1316
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1317
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1318
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1319
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1320
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1321
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1322
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.

Closes #1323
                                                                                                                                                                             Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.
                                                                                                                                                                                     Closes #1272
Copy link
Collaborator

@sarabveer sarabveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarabveer sarabveer changed the title [WIP] Ganj Nama Corrections Ganj Nama Corrections Oct 17, 2019
@bhajneet bhajneet merged commit d3411ef into master Oct 17, 2019
@bhajneet bhajneet deleted the ganj-nama-1st-fixes branch October 17, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts All Affects nearly all or all end-users! Scope: Data/Ganj Nama ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants