-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ganj Nama Corrections #1253
Merged
Merged
Ganj Nama Corrections #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 138, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1252
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 138, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1252
…to ganj-nama-1st-fixes
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 139, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1254
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1255
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1256
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1258
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1259
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1260
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 140, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1261
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1262
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1263
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1264
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1265
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 141, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1266
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1267
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1268
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 142, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1269
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1271
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1273
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1274
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1275
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1276
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 144, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1277
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 145, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1279
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1304
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1305
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1306
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1307
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 153, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1308
These lines occur at the start of each file. Only one (first one) had a different mistake. All 10 have been reviewed with the following proof. Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, pp. 138-154, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1250, Related #1255 and #1256
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 154, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1310
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1311
NJ9Z is the only line that matches the proof with "Guru Gobind" instead of "Gur Gobind" Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, pp. 154-161, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. See also #1310, #1311
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Also missed one instance related to commit f5ab161 Used regex this time to confirm that all instances match each other aside from line NJ9Z for the last 3 words. Closes #1312, Related #1310, #1311
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1313
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1314
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 155, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1315
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 156, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1316
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1317
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1318
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1319
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 157, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1320
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1321
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1322
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 159, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1323
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, p. 143, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019. Closes #1272
sarabveer
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Impacts All
Affects nearly all or all end-users!
Scope: Data/Ganj Nama
○ Type Bug
Regressions/production issues that do not function as intended.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For correctors:
For developers:
Bhai Nand Lal Granthavali. Edited by Ganda Singh, 4th ed., Punjabi University, Patiala, 2009, <PAGE>, www.sikhbookclub.com/Book/Bhai-Nand-Lal-Granthavali. Accessed 22 Jan 2019.
<PAGE>
can be p. 43 or pp. 43-44. Most likely all of these will be found on a single page (e.g. "p. 43"). Use the Times New Roman physical page number found top-left/top-right in the photo of the PDF and not the page number of the PDF document itself.Example git commit
Sanitization:
ˆ
vs stand-alone bindiN
yˆ
toyN
Yˆ
toYN
oˆ
tooN
Oˆ
toON
Iˆ
toIN
auˆ
toauN
ü
/¨
Ru
toRü
RU
toR¨
wN
toW
HU
toH¨
~
vs`
(Adhak)nUM
vsnUµ
R
vs®
(In case ofkR
)N
vsˆ
: "(.{255})",