Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bit masks #24

Open
gpo-geo opened this issue Jul 12, 2019 · 1 comment
Open

Wrong bit masks #24

gpo-geo opened this issue Jul 12, 2019 · 1 comment

Comments

@gpo-geo
Copy link

gpo-geo commented Jul 12, 2019

int m_MasksArray[8] = {0x01, 0x02, 0x04, 0x08, 0x16, 0x32, 0x64, 0x128};

Should be 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80 as the values are hexadecimal.

@lnicola
Copy link
Contributor

lnicola commented Jul 12, 2019

It probably should, and there's no need for an array there as the mask can be produced with a shift. I'll check on Monday what that code is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants