Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "sesp-property-***-desc" system messages #134

Closed
kghbln opened this issue Jan 15, 2020 · 3 comments · Fixed by #138
Closed

Provide "sesp-property-***-desc" system messages #134

kghbln opened this issue Jan 15, 2020 · 3 comments · Fixed by #138
Assignees
Labels
Milestone

Comments

@kghbln
Copy link
Member

kghbln commented Jan 15, 2020

Setup and configuration

  • MediaWiki | 1.31.6 (c168a3f)14:28, 19 December 2019
  • PHP | 7.2.24-0ubuntu0.18.04.1 (apache2handler)
  • MariaDB | 10.1.43-MariaDB-0ubuntu0.18.04.1
  • Semantic MediaWiki | 3.1.2 (e00b175) 09:42, 12 January 2020
  • Semantic Extra Special Properties | 2.0.0 (5a75bb2) 09:33, 12 October 2018

Issue

Refs: #msg36899673

Currently not all extra special properties provided by this extension indicate their origin, e.g. Page ID does whereas Subpage does not.

For the latter and extra special properties showing the same behaviour the "sesp-property-***-desc" system messages are missing and should be provided.

@kghbln kghbln added the bug label Jan 15, 2020
@kghbln kghbln added this to the SESP 3.0.0 milestone Jan 15, 2020
@kghbln kghbln self-assigned this Jan 15, 2020
@kghbln
Copy link
Member Author

kghbln commented Jan 15, 2020

@mwjames I assume that it is just a matter of missing description messages. If so I could take on this task.

@kghbln
Copy link
Member Author

kghbln commented Feb 1, 2020

I guess SemanticMediaWiki/SemanticMediaWiki#4493 got triggered by this issue.

In the end however it is indeed just a matter of adding the missing system messages?

@mwjames
Copy link
Contributor

mwjames commented Feb 1, 2020

In the end however it is indeed just a matter of adding the missing system messages?

Yes.

I guess SemanticMediaWiki/SemanticMediaWiki#4493 got triggered by this issue.

I just came across the missing File attachment description in SMW core due to some refactoring for the FileIndexer and I ended-up creating a test which found the missing ones.

@kghbln kghbln modified the milestones: SESP 3.0.0, SESP 2.1.0 Feb 8, 2020
@kghbln kghbln mentioned this issue Feb 8, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants