forked from openskynetwork/java-adsb
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NACp in v1 and v2 airborne positions #11
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method
public byte getNACp()
is available inAirbornePositionV1Msg
andAirbornePositionV2Msg
through inheritance. Semantically, this is not correct as stated in the Javadoc:Maybe we should make this more explicit?
Alternatives that come to my mind, both overriding the method in
AirbornePositionV1Msg
andAirbornePositionV1Msg
:getNACp
method returns the field value. The field value is set by the state-ful decoder upon reception of anAirborneOperationalStatusMsg
In solution (2), the method will only be used when the
AirbornePositionMsg
is created by an instance ofDecoder
. Note that we have similar behavior already withgetNIC
, where supplements need to be set.The text was updated successfully, but these errors were encountered: