Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put cube data on the x axis if plotting just a cube against a vertical or y coordinate #3906

Merged
merged 7 commits into from
Dec 16, 2020
Merged

Put cube data on the x axis if plotting just a cube against a vertical or y coordinate #3906

merged 7 commits into from
Dec 16, 2020

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Oct 14, 2020 •
edited
Loading

🚀 Pull Request

Description

Take two of #2901, this time with requisite changes to target image-hashes. Have removed references to previous acceptable image-hashes in imagerepo.json since this is a complete change in expected plot rather than just a minor shift.

Twin PR: SciTools/test-iris-imagehash#37.

Consult Iris pull request check list

@trexfeathers trexfeathers mentioned this pull request Oct 14, 2020
Merged
@trexfeathers
Copy link
Contributor Author

Closes #612

@trexfeathers trexfeathers marked this pull request as ready for review October 14, 2020 16:25
@rcomer rcomer linked an issue Oct 14, 2020 that may be closed by this pull request
Automatic selection of vertical axis in 1D plots #612
Closed
@trexfeathers trexfeathers added the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label Oct 21, 2020
@bjlittle bjlittle self-assigned this Oct 21, 2020
@rcomer
Copy link
Member

rcomer commented Dec 13, 2020

I just noticed that this gallery example uses the form plot(cube, coord) in order to get depth onto the y-axis. Is it worth updating that here? I think it would just mean removing two lines (52 and 68) and updating the long comment.

@rcomer rcomer assigned rcomer and unassigned bjlittle Dec 13, 2020
rcomer
rcomer reviewed Dec 13, 2020
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trexfeathers, this looks functionally sound to me. I have some very minor comments for your consideration, but none of them would stop me hitting the merge button once the tests are passing with the new hashes.

lib/iris/plot.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/quickplot/test_plot.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/quickplot/test_plot.py Outdated Show resolved Hide resolved
@trexfeathers
Copy link
Contributor Author

@rcomer I think I agree with your comments and I would like to action them, however I'm currently having some matplotlib install issues that are preventing me from trying anything out (and I'm not really supposed to be doing any Iris work at all!). Will come back to this as soon as I can

@trexfeathers
Copy link
Contributor Author

I just noticed that this gallery example uses the form plot(cube, coord) in order to get depth onto the y-axis. Is it worth updating that here? I think it would just mean removing two lines (52 and 68) and updating the long comment.

I've found at least one other example so I'm going to work through these. I'll mark as Draft to be clear

@trexfeathers trexfeathers marked this pull request as draft December 15, 2020 17:57
@trexfeathers trexfeathers marked this pull request as ready for review December 16, 2020 12:00
@trexfeathers
Copy link
Contributor Author

Back to you @rcomer 🙂

rcomer
rcomer approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trexfeathers, this is looking great and thanks for trawling the User Guide.

Seven years from issue to fix must be some sort of record! 🥳😄

@rcomer rcomer merged commit e4706ab into SciTools:master Dec 16, 2020
@rcomer rcomer added this to the v3.1.0 milestone Dec 16, 2020
tkknight added a commit to tkknight/iris that referenced this pull request Feb 9, 2021
@tkknight
Merge branch 'master' into spelling3
dbcd864 
* master: (23 commits)
  Added text to state the Python version used to build the docs. (SciTools#3989)
  add nox session conda list (SciTools#3990)
  Add abstract cube summary (SciTools#3987)
  automate docs discovery of iris and python versions (SciTools#3981)
  corrected syntax (SciTools#3980)
  core dev whatsnew entry (SciTools#3978)
  moved docs dir and updated references to it (SciTools#3975)
  Fix test_incompatible_dimensions test (SciTools#3977)
  remove explicit URLs for core dev names from latest.rst (SciTools#3973)
  document that iris.coords.Coord is an ABC (SciTools#3971)
  reorganise docs common links + add core devs (SciTools#3972)
  Docs whatsnew add dropdowns to the template (SciTools#3969)
  Docs whatsnew enumerated lists (SciTools#3970)
  Merge back v3p0p1 (SciTools#3966)
  Captilise installation heading - align SciTools#3958 content with SciTools#3940. (SciTools#3963)
  Merge back v3p0p0 (SciTools#3960)
  Extended the installation description (SciTools#3958)
  Put cube data on the x axis if plotting just a cube against a vertical or y coordinate (SciTools#3906)
  remove stock_mdi_arrays.npz (SciTools#3913)
  Gallery: update seasonal ensemble example (SciTools#3933)
  ...
@trexfeathers trexfeathers deleted the 1d_plot_against_yz branch February 23, 2021 11:19
Closed
@rcomer rcomer mentioned this pull request Feb 24, 2022
Merged
@rcomer rcomer mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcomer rcomer rcomer approved these changes

Assignees

@rcomer rcomer

Labels
Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Automatic selection of vertical axis in 1D plots
3 participants
@trexfeathers @rcomer @bjlittle