-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put cube data on the x axis if plotting just a cube against a vertical or y coordinate #3906
Conversation
Closes #612 |
e628008
to
c6136d3
Compare
I just noticed that this gallery example uses the form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @trexfeathers, this looks functionally sound to me. I have some very minor comments for your consideration, but none of them would stop me hitting the merge button once the tests are passing with the new hashes.
@rcomer I think I agree with your comments and I would like to action them, however I'm currently having some |
I've found at least one other example so I'm going to work through these. I'll mark as Draft to be clear |
Back to you @rcomer 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @trexfeathers, this is looking great and thanks for trawling the User Guide.
Seven years from issue to fix must be some sort of record! 🥳😄
* master: (23 commits) Added text to state the Python version used to build the docs. (SciTools#3989) add nox session conda list (SciTools#3990) Add abstract cube summary (SciTools#3987) automate docs discovery of iris and python versions (SciTools#3981) corrected syntax (SciTools#3980) core dev whatsnew entry (SciTools#3978) moved docs dir and updated references to it (SciTools#3975) Fix test_incompatible_dimensions test (SciTools#3977) remove explicit URLs for core dev names from latest.rst (SciTools#3973) document that iris.coords.Coord is an ABC (SciTools#3971) reorganise docs common links + add core devs (SciTools#3972) Docs whatsnew add dropdowns to the template (SciTools#3969) Docs whatsnew enumerated lists (SciTools#3970) Merge back v3p0p1 (SciTools#3966) Captilise installation heading - align SciTools#3958 content with SciTools#3940. (SciTools#3963) Merge back v3p0p0 (SciTools#3960) Extended the installation description (SciTools#3958) Put cube data on the x axis if plotting just a cube against a vertical or y coordinate (SciTools#3906) remove stock_mdi_arrays.npz (SciTools#3913) Gallery: update seasonal ensemble example (SciTools#3933) ...
🚀 Pull Request
Description
Take two of #2901, this time with requisite changes to target image-hashes. Have removed references to previous acceptable image-hashes in
imagerepo.json
since this is a complete change in expected plot rather than just a minor shift.Twin PR: SciTools/test-iris-imagehash#37.
Consult Iris pull request check list