-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why can we define a HybridPressureFactory
without surface air pressure
#6072
Comments
@SciTools/peloton I believe this is due to generic code which will replace missing dependencies with 0. It seems like this effectively leads to nonsense in the case of |
Thanks for the answer @stephenworsley! It's not super critical to me, but I think it would be helpful if iris would not create the factory if one of the formula terms is invalid instead of building a (potentially) wrong coordinate. I know that there is a warning, but it's super easy to ignore that, especially if the derived coordinate is present in the cube. |
From @SciTools/peloton we think this is a good idea, but we're currently very resource-limited, so it's hard to see when this can get done. |
📰 Custom Issue
Iris allows defining a
HybridPressureFactory
without specifying a surface air pressure coordinate. The coordinate will be treated as 0 in this case.I encountered this problem in a file with an invalid
formula_terms: ap: ap b: ap ps: ps
whereps
does not exist in the cube. This will lead to the warningIrisCfMissingVarWarning: Missing CF-netCDF formula term variable 'ps', referenced by netCDF variable 'lev'
, but apart from that the cube is loaded and a wrong air pressure coordinate is created.What's the reasoning behind this to allow that? I would have expected an error similar to the one that is raised for the
AtmosphereSigmaFactory
.A similar problem happens for the
HybridHeightFactory
, which can also be created without orography.The text was updated successfully, but these errors were encountered: