Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Shift(s): e92e36ac #6001

Open
github-actions bot opened this issue Jun 11, 2024 · 1 comment
Open

Performance Shift(s): e92e36ac #6001

github-actions bot opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

Benchmark comparison has identified performance shifts at:

Please review the report below and take corrective/congratulatory action as appropriate :slightly_smiling_face:

⏱️ Performance Benchmark Report: e92e36a

Performance shifts
| Change   |   Before [4cf1767a] <main~1> |   After [e92e36ac] <main> |   Ratio | Benchmark (Parameter)                                |
|----------|------------------------------|---------------------------|---------|------------------------------------------------------|
| +        |                          1.6 |                         2 |    1.25 | save.NetcdfSave.track_addedmem_netcdf_save(50, True) |
Full benchmark results

Benchmarks that have stayed the same:

| Change   | Before [4cf1767a] <main~1>   | After [e92e36ac] <main>   |   Ratio | Benchmark (Parameter)                                                                                  |
|----------|------------------------------|---------------------------|---------|--------------------------------------------------------------------------------------------------------|
|          | 54.0±0.4ms                   | 53.8±0.6ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                                         |
|          | 54.7±0.6ms                   | 55.1±0.6ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                                          |
|          | 190±2ms                      | 189±2ms                   |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                               |
|          | 190±2ms                      | 190±2ms                   |    1    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                                |
|          | 36.5±0.6ms                   | 37.0±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                                         |
|          | 37.3±0.5ms                   | 37.8±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                                          |
|          | 36.8±0.4ms                   | 36.8±0.7ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                                         |
|          | 37.5±0.3ms                   | 37.9±0.6ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                                          |
|          | 46.7±0.5ms                   | 46.9±0.4ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                           |
|          | 47.5±0.4ms                   | 47.6±0.6ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                            |
|          | 120±1ms                      | 120±1ms                   |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                                       |
|          | 121±1ms                      | 121±1ms                   |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                                        |
|          | 51.7±0.6ms                   | 51.7±0.5ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                                          |
|          | 52.1±0.5ms                   | 52.6±0.8ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                           |
|          | 36.2±0.5ms                   | 36.4±0.4ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                                        |
|          | 37.6±0.6ms                   | 37.3±0.6ms                |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                                         |
|          | 46.8±0.6ms                   | 47.0±0.5ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                           |
|          | 47.9±0.6ms                   | 48.0±0.5ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                            |
|          | 1.32±0.01s                   | 1.33±0.01s                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                                          |
|          | 1.32±0.02s                   | 1.34±0.01s                |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                           |
|          | 686±20ms                     | 683±10ms                  |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                                    |
|          | 676±8ms                      | 682±10ms                  |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                                     |
|          | 35.3±0.4ms                   | 35.3±0.3ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                                    |
|          | 35.5±0.3ms                   | 36.1±0.3ms                |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                                     |
|          | 61.3±0.9ms                   | 62.1±0.8ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                           |
|          | 61.9±0.5ms                   | 62.4±0.7ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                            |
|          | 66.2±0.8ms                   | 66.7±0.7ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                                       |
|          | 67.1±0.7ms                   | 67.8±0.6ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                                        |
|          | 61.7±0.6ms                   | 61.8±0.9ms                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                                      |
|          | 62.2±0.8ms                   | 62.5±0.7ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                                       |
|          | 20.0±0.5ms                   | 19.8±0.2ms                |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                                          |
|          | 23.5±0.3ms                   | 23.8±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                           |
|          | 129±0.9ms                    | 129±0.9ms                 |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                                |
|          | 143±1ms                      | 142±0.6ms                 |    1    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                                 |
|          | 18.1±0.3ms                   | 18.2±0.6ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                                          |
|          | 22.0±0.5ms                   | 22.2±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                           |
|          | 18.1±0.3ms                   | 18.0±0.3ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                                          |
|          | 22.0±0.5ms                   | 22.2±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                           |
|          | 18.6±0.3ms                   | 18.7±0.4ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                            |
|          | 22.3±0.4ms                   | 22.5±0.2ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                             |
|          | 34.9±0.5ms                   | 34.9±1ms                  |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                                        |
|          | 38.1±1ms                     | 38.3±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                                         |
|          | 19.0±0.2ms                   | 19.0±0.2ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                           |
|          | 22.8±0.9ms                   | 23.0±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                            |
|          | 18.6±0.2ms                   | 18.9±0.4ms                |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                                         |
|          | 22.6±0.2ms                   | 22.8±0.4ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                                          |
|          | 18.6±0.3ms                   | 18.7±0.2ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                            |
|          | 22.4±0.3ms                   | 22.6±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                             |
|          | 551±6ms                      | 552±3ms                   |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                           |
|          | 566±9ms                      | 558±7ms                   |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                            |
|          | 149±0.7ms                    | 149±0.6ms                 |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                                     |
|          | 166±0.8ms                    | 167±1ms                   |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                                      |
|          | 17.8±0.3ms                   | 17.7±0.6ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                                     |
|          | 21.7±0.2ms                   | 21.8±0.3ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                                      |
|          | 21.1±0.3ms                   | 21.1±0.4ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                            |
|          | 24.8±0.3ms                   | 24.9±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                             |
|          | 21.1±0.3ms                   | 21.3±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                                        |
|          | 25.0±0.4ms                   | 25.1±0.3ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                                         |
|          | 20.7±0.5ms                   | 20.7±0.5ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                                       |
|          | 24.2±0.4ms                   | 24.5±0.4ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                                        |
|          | 83.2±0.7ms                   | 83.9±0.6ms                |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                                |
|          | 84.8±0.8ms                   | 84.7±1ms                  |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                                 |
|          | 94.9±0.6ms                   | 95.8±0.8ms                |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                                 |
|          | 95.5±0.8ms                   | 96.4±1ms                  |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                                  |
|          | 57.6±0.8ms                   | 57.8±0.5ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                                 |
|          | 58.6±0.7ms                   | 59.0±1ms                  |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                                  |
|          | 29.5±0.5ms                   | 29.2±0.3ms                |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                                 |
|          | 32.9±0.6ms                   | 33.2±0.4ms                |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                                  |
|          | 31.4±0.4ms                   | 31.4±0.5ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                                  |
|          | 35.0±0.5ms                   | 35.7±0.6ms                |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                                   |
|          | 25.9±0.2ms                   | 25.8±0.5ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                                  |
|          | 29.5±0.3ms                   | 29.7±0.6ms                |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                                   |
|          | 324±4ms                      | 327±3ms                   |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)                          |
|          | 345±3ms                      | 347±3ms                   |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                           |
|          | 1.13±0.01ms                  | 1.13±0.01ms               |    1    | cube.CubeCreation.time_create(False, 'construct')                                                      |
|          | 406±6μs                      | 404±4μs                   |    0.99 | cube.CubeCreation.time_create(False, 'instantiate')                                                    |
|          | 965±20μs                     | 972±10μs                  |    1.01 | cube.CubeCreation.time_create(True, 'construct')                                                       |
|          | 592±7μs                      | 577±7μs                   |    0.97 | cube.CubeCreation.time_create(True, 'instantiate')                                                     |
|          | 223±2ms                      | 223±3ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                             |
|          | 113±2ms                      | 112±2ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                                      |
|          | 233±3ms                      | 233±3ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                                       |
|          | 16.6±0.2μs                   | 16.8±0.3μs                |    1.02 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                                   |
|          | 304±2ms                      | 305±4ms                   |    1    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                              |
|          | 198±3ms                      | 199±3ms                   |    1    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                                       |
|          | 317±3ms                      | 320±3ms                   |    1.01 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                                        |
|          | 16.8±0.2μs                   | 17.0±0.1μs                |    1.01 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                                    |
|          | 224±2ms                      | 221±4ms                   |    0.99 | cube.CubeEquality.time_equality(True, False, 'all_equal')                                              |
|          | 113±1ms                      | 112±2ms                   |    1    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                                       |
|          | 232±2ms                      | 233±2ms                   |    1.01 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                                        |
|          | 53.9±0.5μs                   | 53.8±0.5μs                |    1    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                                    |
|          | 307±3ms                      | 307±4ms                   |    1    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                               |
|          | 200±1ms                      | 197±2ms                   |    0.99 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                                        |
|          | 314±3ms                      | 316±2ms                   |    1.01 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                                         |
|          | 55.7±0.7μs                   | 55.2±0.7μs                |    0.99 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                                     |
|          | 397±2ns                      | 395±2ns                   |    1    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)                 |
|          | 261±2ms                      | 258±3ms                   |    0.99 | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)                |
|          | 0.6                          | 0.6                       |    1    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.track_addedmem_compute_data(50)       |
|          | 57.3                         | 57.3                      |    1    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.track_addedmem_compute_data(500)      |
|          | 14.6±0.09ms                  | 14.7±0.1ms                |    1.01 | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)              |
|          | 16.5±0.3ms                   | 16.5±0.3ms                |    1    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)             |
|          | 0.5                          | 0.5                       |    1    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(50)    |
|          | 11.8                         | 11.8                      |    1    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(500)   |
|          | 105±0.6ms                    | 105±0.6ms                 |    1    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)            |
|          | 706±3ms                      | 708±4ms                   |    1    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)           |
|          | 1.4                          | 1.3                       |    0.93 | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.track_addedmem_stream_file2file(50)  |
|          | 92.0                         | 92.0                      |    1    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.track_addedmem_stream_file2file(500) |
|          | 66.0±0.7ms                   | 67.4±0.5ms                |    1.02 | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(50)                                |
|          | 661±3ms                      | 660±3ms                   |    1    | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(500)                               |
|          | 1.3                          | 1.4                       |    1.08 | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_addedmem_save(50)                      |
|          | 92.0                         | 92.0                      |    1    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_addedmem_save(500)                     |
|          | 2.1752849999999997           | 2.1752849999999997        |    1    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                     |
|          | 216.01528499999998           | 216.01528499999998        |    1    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                    |
|          | 674±7μs                      | 669±3μs                   |    0.99 | import_iris.Iris.time__concatenate                                                                     |
|          | 181±2μs                      | 183±2μs                   |    1.02 | import_iris.Iris.time__constraints                                                                     |
|          | 111±1μs                      | 112±2μs                   |    1.01 | import_iris.Iris.time__data_manager                                                                    |
|          | 94.4±0.5μs                   | 96.0±1μs                  |    1.02 | import_iris.Iris.time__deprecation                                                                     |
|          | 136±1μs                      | 139±0.8μs                 |    1.02 | import_iris.Iris.time__lazy_data                                                                       |
|          | 905±20μs                     | 917±10μs                  |    1.01 | import_iris.Iris.time__merge                                                                           |
|          | 79.1±0.6μs                   | 79.1±0.5μs                |    1    | import_iris.Iris.time__representation                                                                  |
|          | 480±3μs                      | 490±8μs                   |    1.02 | import_iris.Iris.time_analysis                                                                         |
|          | 141±1μs                      | 142±2μs                   |    1.01 | import_iris.Iris.time_analysis__area_weighted                                                          |
|          | 109±2μs                      | 111±2μs                   |    1.02 | import_iris.Iris.time_analysis__grid_angles                                                            |
|          | 244±1μs                      | 245±2μs                   |    1    | import_iris.Iris.time_analysis__interpolation                                                          |
|          | 190±3μs                      | 189±2μs                   |    1    | import_iris.Iris.time_analysis__regrid                                                                 |
|          | 113±0.7μs                    | 113±0.7μs                 |    1    | import_iris.Iris.time_analysis__scipy_interpolate                                                      |
|          | 139±0.8μs                    | 142±3μs                   |    1.02 | import_iris.Iris.time_analysis_calculus                                                                |
|          | 332±5μs                      | 329±3μs                   |    0.99 | import_iris.Iris.time_analysis_cartography                                                             |
|          | 94.5±1μs                     | 94.4±2μs                  |    1    | import_iris.Iris.time_analysis_geomerty                                                                |
|          | 216±2μs                      | 220±2μs                   |    1.02 | import_iris.Iris.time_analysis_maths                                                                   |
|          | 98.6±0.5μs                   | 99.4±0.9μs                |    1.01 | import_iris.Iris.time_analysis_stats                                                                   |
|          | 175±1μs                      | 176±2μs                   |    1    | import_iris.Iris.time_analysis_trajectory                                                              |
|          | 309±8μs                      | 313±6μs                   |    1.01 | import_iris.Iris.time_aux_factory                                                                      |
|          | 85.2±0.4μs                   | 87.0±0.6μs                |    1.02 | import_iris.Iris.time_common                                                                           |
|          | 164±2μs                      | 164±2μs                   |    1    | import_iris.Iris.time_common_lenient                                                                   |
|          | 987±4μs                      | 989±10μs                  |    1    | import_iris.Iris.time_common_metadata                                                                  |
|          | 136±2μs                      | 135±2μs                   |    1    | import_iris.Iris.time_common_mixin                                                                     |
|          | 1.18±0.01ms                  | 1.18±0.01ms               |    1    | import_iris.Iris.time_common_resolve                                                                   |
|          | 201±2μs                      | 203±1μs                   |    1.01 | import_iris.Iris.time_config                                                                           |
|          | 116±2μs                      | 118±1μs                   |    1.02 | import_iris.Iris.time_coord_categorisation                                                             |
|          | 358±3μs                      | 359±4μs                   |    1    | import_iris.Iris.time_coord_systems                                                                    |
|          | 745±9μs                      | 746±7μs                   |    1    | import_iris.Iris.time_coords                                                                           |
|          | 670±7μs                      | 667±7μs                   |    1    | import_iris.Iris.time_cube                                                                             |
|          | 224±1μs                      | 225±2μs                   |    1    | import_iris.Iris.time_exceptions                                                                       |
|          | 79.2±2μs                     | 79.4±0.7μs                |    1    | import_iris.Iris.time_experimental                                                                     |
|          | 188±1μs                      | 190±1μs                   |    1.01 | import_iris.Iris.time_fileformats                                                                      |
|          | 251±2μs                      | 253±1μs                   |    1.01 | import_iris.Iris.time_fileformats__ff                                                                  |
|          | 2.71±0.01ms                  | 2.72±0.02ms               |    1    | import_iris.Iris.time_fileformats__ff_cross_references                                                 |
|          | 80.0±0.2μs                   | 80.5±0.8μs                |    1.01 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                                     |
|          | 115±1μs                      | 117±0.9μs                 |    1.01 | import_iris.Iris.time_fileformats_abf                                                                  |
|          | 354±6μs                      | 354±3μs                   |    1    | import_iris.Iris.time_fileformats_cf                                                                   |
|          | 5.44±0.1ms                   | 5.42±0.07ms               |    1    | import_iris.Iris.time_fileformats_dot                                                                  |
|          | 75.0±0.4μs                   | 77.0±0.6μs                |    1.03 | import_iris.Iris.time_fileformats_name                                                                 |
|          | 264±5μs                      | 261±2μs                   |    0.99 | import_iris.Iris.time_fileformats_name_loaders                                                         |
|          | 120±1μs                      | 119±1μs                   |    0.99 | import_iris.Iris.time_fileformats_netcdf                                                               |
|          | 124±1μs                      | 125±1μs                   |    1.01 | import_iris.Iris.time_fileformats_nimrod                                                               |
|          | 210±3μs                      | 212±4μs                   |    1.01 | import_iris.Iris.time_fileformats_nimrod_load_rules                                                    |
|          | 780±6μs                      | 788±8μs                   |    1.01 | import_iris.Iris.time_fileformats_pp                                                                   |
|          | 181±2μs                      | 181±2μs                   |    1    | import_iris.Iris.time_fileformats_pp_load_rules                                                        |
|          | 134±2μs                      | 137±0.8μs                 |    1.02 | import_iris.Iris.time_fileformats_pp_save_rules                                                        |
|          | 518±3μs                      | 517±3μs                   |    1    | import_iris.Iris.time_fileformats_rules                                                                |
|          | 224±3μs                      | 222±2μs                   |    0.99 | import_iris.Iris.time_fileformats_structured_array_identification                                      |
|          | 85.5±0.6μs                   | 85.2±0.5μs                |    1    | import_iris.Iris.time_fileformats_um                                                                   |
|          | 162±0.6μs                    | 163±1μs                   |    1    | import_iris.Iris.time_fileformats_um__fast_load                                                        |
|          | 138±2μs                      | 139±0.7μs                 |    1    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                                      |
|          | 77.2±0.4μs                   | 77.4±1μs                  |    1    | import_iris.Iris.time_fileformats_um__ff_replacement                                                   |
|          | 82.0±1μs                     | 83.3±0.8μs                |    1.02 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                                        |
|          | 978±5μs                      | 988±8μs                   |    1.01 | import_iris.Iris.time_fileformats_um_cf_map                                                            |
|          | 137±1μs                      | 138±2μs                   |    1.01 | import_iris.Iris.time_io                                                                               |
|          | 172±2μs                      | 174±2μs                   |    1.01 | import_iris.Iris.time_io_format_picker                                                                 |
|          | 205±1μs                      | 209±2μs                   |    1.02 | import_iris.Iris.time_iris                                                                             |
|          | 128±0.5μs                    | 129±0.4μs                 |    1.01 | import_iris.Iris.time_iterate                                                                          |
|          | 8.58±0.04ms                  | 8.60±0.1ms                |    1    | import_iris.Iris.time_palette                                                                          |
|          | 2.20±0.04ms                  | 2.21±0.04ms               |    1    | import_iris.Iris.time_plot                                                                             |
|          | 104±0.6μs                    | 106±1μs                   |    1.01 | import_iris.Iris.time_quickplot                                                                        |
|          | 2.13±0.01ms                  | 2.15±0.01ms               |    1.01 | import_iris.Iris.time_std_names                                                                        |
|          | 1.76±0.01ms                  | 1.79±0.03ms               |    1.02 | import_iris.Iris.time_symbols                                                                          |
|          | 34.1±0.6ms                   | 34.5±0.9ms                |    1.01 | import_iris.Iris.time_tests                                                                            |
|          | 231±2μs                      | 235±3μs                   |    1.02 | import_iris.Iris.time_third_party_cartopy                                                              |
|          | 4.76±0.03ms                  | 4.79±0.04ms               |    1.01 | import_iris.Iris.time_third_party_cf_units                                                             |
|          | 108±0.9μs                    | 109±1μs                   |    1.01 | import_iris.Iris.time_third_party_cftime                                                               |
|          | 2.81±0.01ms                  | 2.82±0.02ms               |    1    | import_iris.Iris.time_third_party_matplotlib                                                           |
|          | 1.06±0ms                     | 1.06±0ms                  |    0.99 | import_iris.Iris.time_third_party_numpy                                                                |
|          | 160±2μs                      | 159±2μs                   |    1    | import_iris.Iris.time_third_party_scipy                                                                |
|          | 101±0.5μs                    | 101±0.5μs                 |    1    | import_iris.Iris.time_time                                                                             |
|          | 323±2μs                      | 323±5μs                   |    1    | import_iris.Iris.time_util                                                                             |
|          | 74.0±0.8μs                   | 74.7±0.8μs                |    1.01 | iterate.IZip.time_izip                                                                                 |
|          | 8.15±0.03ms                  | 8.12±0.07ms               |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                             |
|          | 24.0±0.2ms                   | 23.9±0.2ms                |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                                         |
|          | 8.91±0.1ms                   | 8.98±0.1ms                |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                             |
|          | 8.15±0.07ms                  | 8.12±0.03ms               |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                              |
|          | 21.0±0.2ms                   | 21.3±0.4ms                |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                                          |
|          | 8.83±0.04ms                  | 8.99±0.1ms                |    1.02 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                              |
|          | 1.37±0.02s                   | 1.38±0.02s                |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                               |
|          | 21.2±0.3ms                   | 20.9±0.4ms                |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                           |
|          | 1.53±0.01s                   | 1.54±0.02s                |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                               |
|          | 1.36±0.02s                   | 1.37±0s                   |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                                |
|          | 21.1±0.3ms                   | 20.7±0.2ms                |    0.98 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                            |
|          | 1.54±0.02s                   | 1.53±0.01s                |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                                |
|          | 3.93±0.02ms                  | 3.95±0.05ms               |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                                |
|          | 19.7±0.2ms                   | 19.7±0.1ms                |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                            |
|          | 4.20±0.02ms                  | 4.24±0.03ms               |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                                |
|          | 3.94±0.02ms                  | 4.00±0.06ms               |    1.02 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                                 |
|          | 19.7±0.3ms                   | 19.9±0.3ms                |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                             |
|          | 4.19±0.02ms                  | 4.23±0.03ms               |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                                 |
|          | 31.3±2ms                     | 31.2±1ms                  |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                                          |
|          | 18.5±0.2ms                   | 18.7±0.5ms                |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                                      |
|          | 13.4±1ms                     | 12.9±2ms                  |    0.96 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                                          |
|          | 25.7±2ms                     | 25.5±1ms                  |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                           |
|          | 70.1±2ms                     | 70.5±2ms                  |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                                       |
|          | 25.8±1ms                     | 25.5±2ms                  |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                           |
|          | 447±2ms                      | 444±3ms                   |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                            |
|          | 2.89±0.1ms                   | 2.87±0.2ms                |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                                        |
|          | 453±2ms                      | 451±3ms                   |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                            |
|          | 452±3ms                      | 451±3ms                   |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                             |
|          | 2.88±0.05ms                  | 2.90±0.08ms               |    1.01 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                                         |
|          | 456±3ms                      | 455±3ms                   |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                             |
|          | 1.59±0.07ms                  | 1.59±0.09ms               |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                             |
|          | 2.83±0.1ms                   | 2.88±0.1ms                |    1.02 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                                         |
|          | 1.60±0.06ms                  | 1.63±0.1ms                |    1.02 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                             |
|          | 1.58±0.05ms                  | 1.59±0.08ms               |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                              |
|          | 2.98±0.2ms                   | 2.80±0.1ms                |    0.94 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                                          |
|          | 1.62±0.07ms                  | 1.58±0.09ms               |    0.97 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                              |
|          | 354±4ms                      | 352±4ms                   |    1    | load.ManyVars.time_many_var_load                                                                       |
|          | 8.26±0.03ms                  | 8.34±0.06ms               |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                                       |
|          | 9.10±0.05ms                  | 9.16±0.05ms               |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                                       |
|          | 1.38±0.01s                   | 1.38±0.01s                |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                                         |
|          | 1.55±0.01s                   | 1.55±0.01s                |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                                         |
|          | 4.00±0.01ms                  | 4.02±0.03ms               |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                            |
|          | 4.26±0.05ms                  | 4.34±0.04ms               |    1.02 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                            |
|          | 8.15±0.04ms                  | 8.18±0.02ms               |    1    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                                          |
|          | 4.83±0.02ms                  | 4.84±0.06ms               |    1    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                           |
|          | 1.36±0.02s                   | 1.37±0.01s                |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                            |
|          | 377±2ms                      | 375±2ms                   |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                             |
|          | 3.95±0.02ms                  | 3.96±0.01ms               |    1    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                               |
|          | 3.59±0.04ms                  | 3.59±0.02ms               |    1    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                                |
|          | 147±0.9ms                    | 147±1ms                   |    1    | load.TimeConstraint.time_time_constraint(20, 'FF')                                                     |
|          | 23.2±0.4ms                   | 23.3±0.4ms                |    1.01 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                                 |
|          | 163±2ms                      | 162±0.8ms                 |    1    | load.TimeConstraint.time_time_constraint(20, 'PP')                                                     |
|          | 29.3±0.3ms                   | 29.1±0.2ms                |    0.99 | load.TimeConstraint.time_time_constraint(3, 'FF')                                                      |
|          | 22.8±0.1ms                   | 23.3±0.3ms                |    1.02 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                                  |
|          | 31.4±0.2ms                   | 31.6±0.3ms                |    1.01 | load.TimeConstraint.time_time_constraint(3, 'PP')                                                      |
|          | 17.8±0.4ms                   | 17.8±0.3ms                |    1    | load.ugrid.BasicLoading.time_load_file(1)                                                              |
|          | 41.7±0.9ms                   | 41.5±0.6ms                |    1    | load.ugrid.BasicLoading.time_load_file(200000)                                                         |
|          | 14.2±0.3ms                   | 14.1±0.3ms                |    0.99 | load.ugrid.BasicLoading.time_load_mesh(1)                                                              |
|          | 22.3±0.4ms                   | 22.5±0.4ms                |    1.01 | load.ugrid.BasicLoading.time_load_mesh(200000)                                                         |
|          | 17.6±0.2ms                   | 17.8±0.4ms                |    1.01 | load.ugrid.BasicLoadingTime.time_load_file(1)                                                          |
|          | 20.7±0.6ms                   | 20.7±0.5ms                |    1    | load.ugrid.BasicLoadingTime.time_load_file(200000)                                                     |
|          | 14.0±0.2ms                   | 14.2±0.3ms                |    1.01 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                                          |
|          | 17.1±0.4ms                   | 16.8±0.4ms                |    0.99 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                                     |
|          | 18.8±0.5ms                   | 18.3±0.1ms                |    0.97 | load.ugrid.Callback.time_load_file_callback(1)                                                         |
|          | 52.1±0.5ms                   | 51.0±0.8ms                |    0.98 | load.ugrid.Callback.time_load_file_callback(200000)                                                    |
|          | 18.9±0.4ms                   | 18.5±0.4ms                |    0.98 | load.ugrid.CallbackTime.time_load_file_callback(1)                                                     |
|          | 22.9±0.4ms                   | 22.5±0.6ms                |    0.98 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                                |
|          | 2.81±0.1ms                   | 2.79±0.09ms               |    0.99 | load.ugrid.DataRealisation.time_realise_data(10000)                                                    |
|          | 3.99±0.8ms                   | 3.98±0.9ms                |    1    | load.ugrid.DataRealisation.time_realise_data(200000)                                                   |
|          | 38.4±0.9ms                   | 37.9±1ms                  |    0.99 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                                |
|          | 795±9ms                      | 798±3ms                   |    1    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                               |
|          | 185±2ms                      | 185±2ms                   |    1    | merge_concat.Concatenate.time_concatenate                                                              |
|          | 226.9                        | 226.9                     |    1    | merge_concat.Concatenate.track_mem_merge                                                               |
|          | 46.6±0.6ms                   | 47.0±0.6ms                |    1.01 | merge_concat.Merge.time_merge                                                                          |
|          | 10.8                         | 10.8                      |    1    | merge_concat.Merge.track_mem_merge                                                                     |
|          | 6.55±0.02ms                  | 6.58±0.02ms               |    1    | plot.AuxSort.time_aux_sort                                                                             |
|          | 78.0±5ms                     | 80.7±4ms                  |    1.03 | regridding.CurvilinearRegridding.time_regrid_pic                                                       |
|          | 144.8                        | 144.8                     |    1    | regridding.CurvilinearRegridding.track_mem_regrid_pic                                                  |
|          | 98.8±0.7ms                   | 98.8±0.7ms                |    1    | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                              |
|          | 49.4±2ms                     | 48.6±1ms                  |    0.98 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                                     |
|          | 111.5                        | 111.5                     |    1    | regridding.HorizontalChunkedRegridding.track_mem_regrid_area_w                                         |
|          | 151.6                        | 151.6                     |    1    | regridding.HorizontalChunkedRegridding.track_mem_regrid_area_w_new_grid                                |
|          | 4.09±0.07ms                  | 4.12±0.05ms               |    1.01 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                                       |
|          | 71.9±0.5ms                   | 72.8±1ms                  |    1.01 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                                        |
|          | 52.3±0.5ms                   | 53.0±1ms                  |    1.01 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                                      |
|          | 565±2ms                      | 563±5ms                   |    1    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                                       |
|          | 90.1±0.8ns                   | 91.4±3ns                  |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                                       |
|          | 55.1±0.5ms                   | 55.4±0.6ms                |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                                        |
|          | 89.8±1ns                     | 90.9±3ns                  |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                                      |
|          | 494±3ms                      | 498±4ms                   |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                                       |
|          | 0.3                          | 0.3                       |    1    | save.NetcdfSave.track_addedmem_netcdf_save(50, False)                                                  |
|          | 0.3                          | 0.3                       |    1    | save.NetcdfSave.track_addedmem_netcdf_save(600, False)                                                 |
|          | 181.7                        | 214.6                     |    1.18 | save.NetcdfSave.track_addedmem_netcdf_save(600, True)                                                  |
|          | 42.5±0.7ms                   | 42.2±1ms                  |    0.99 | stats.PearsonR.time_lazy                                                                               |
|          | 18.8±0.3ms                   | 18.9±0.2ms                |    1    | stats.PearsonR.time_real                                                                               |
|          | 19.4                         | 19.4                      |    1    | stats.PearsonR.track_lazy                                                                              |
|          | 17.8                         | 17.8                      |    1    | stats.PearsonR.track_real                                                                              |
|          | 23.4±1ms                     | 23.8±0.8ms                |    1.02 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                              |
|          | 58.1±0.6ms                   | 59.1±1ms                  |    1.02 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                             |
|          | 32.1                         | 32.1                      |    1    | trajectory.TrajectoryInterpolation.track_trajectory_linear                                             |
|          | 21.5                         | 21.5                      |    1    | trajectory.TrajectoryInterpolation.track_trajectory_nearest                                            |

Benchmarks that have got worse:

| Change   |   Before [4cf1767a] <main~1> |   After [e92e36ac] <main> |   Ratio | Benchmark (Parameter)                                |
|----------|------------------------------|---------------------------|---------|------------------------------------------------------|
| +        |                          1.6 |                         2 |    1.25 | save.NetcdfSave.track_addedmem_netcdf_save(50, True) |

Generated by GHA run 9473887479

@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels Jun 11, 2024
@trexfeathers
Copy link
Contributor

trexfeathers commented Jun 14, 2024

Note that I have a potential solution to the memory benchmarks being noisy, but it needs more exploration:

#5981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
Status: No status
Development

No branches or pull requests

2 participants