Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding space for memory benchmarking issues #5967

Open
pp-mo opened this issue May 21, 2024 · 2 comments
Open

Holding space for memory benchmarking issues #5967

pp-mo opened this issue May 21, 2024 · 2 comments

Comments

@pp-mo
Copy link
Member

pp-mo commented May 21, 2024

Since #5960, #5959 , #5950 and especially #5948
We are likely to get a few change warnings from memory benchmarks.

Doubtless some sensitivity changes may be needed, perhaps we'll have to turn off most of the memory benchmarking again. But possibly also, it will need to "settle down" after recent changes ?
I think we should just routinely close these for a while, and later review as a set.

Issues referencing this one will be visible below ...

@trexfeathers
Copy link
Contributor

If we feel we might benefit from repetitions, we could try writing our own benchmark class - ASV is designed for this and they are not as complex as I feared.

@trexfeathers
Copy link
Contributor

trexfeathers commented May 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants