Support NetCDF v3 files in chunking control code. #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note from offline discussion with @trexfeathers . I also attempted to include the context-operation "improvements" that I discussed, but they caused unexpected failures. Something there is clearly not working the way I thought, so I'll leave that to another day. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5897 +/- ##
==========================================
+ Coverage 89.73% 89.76% +0.03%
==========================================
Files 92 93 +1
Lines 22898 22982 +84
Branches 5453 5477 +24
==========================================
+ Hits 20547 20630 +83
- Misses 1620 1622 +2
+ Partials 731 730 -1 ☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Apr 3, 2024
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 3, 2024
* upstream/main: (163 commits) Restore latest Whats New files. Whats new updates for `v3.9.0rc0` (SciTools#5899) nep29: drop py39 and support py312 (SciTools#5894) Support NetCDF v3 files in chunking control code. (SciTools#5897) Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896) Force pytest colour output on GitHub Actions (SciTools#5895) Make typing 3.9 compatible. Improve typing readability. Updated environment lockfiles (SciTools#5892) [pre-commit.ci] pre-commit autoupdate What's New entry for SciTools#5740 . Iris to GeoVista conversion (SciTools#5740) Try Union for type hinting. Type hinting. Fix typo. Re-introduce backwards compatible warning. Updated documentation. Remove loose references to fill value warnings. Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate ...
|
great work here! I'd have put a massive exception "Don't blithering feed me NETCDF3 data!" instead, if I was you, though 🤣 |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 10, 2024
…th_numpydoc * upstream/main: (39 commits) Bump scitools/workflows from 2024.03.3 to 2024.04.0 (SciTools#5907) [pre-commit.ci] pre-commit autoupdate (SciTools#5906) Updated environment lockfiles (SciTools#5904) Ignore flaticon.com in linkchecks. (SciTools#5905) Implement lazy area weights (SciTools#5658) Add option to specify chunks in `iris.util.broadcast_to_shape` (SciTools#5620) Unpin sphinx (SciTools#5901) DOC: clarify save_pairs_from_cube docstring (SciTools#5783) Restore latest Whats New files. Whats new updates for `v3.9.0rc0` (SciTools#5899) nep29: drop py39 and support py312 (SciTools#5894) Support NetCDF v3 files in chunking control code. (SciTools#5897) Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896) Force pytest colour output on GitHub Actions (SciTools#5895) Make typing 3.9 compatible. Improve typing readability. Updated environment lockfiles (SciTools#5892) [pre-commit.ci] pre-commit autoupdate What's New entry for SciTools#5740 . Iris to GeoVista conversion (SciTools#5740) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5864
This supports when a netcdf variable ".chunking()" call returns
None.The added test fails without the fix.