Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests in unit/util to pytest #5853

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Convert tests in unit/util to pytest #5853

merged 8 commits into from
Mar 19, 2024

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Mar 18, 2024 •
edited
Loading

closes #5855

@ESadek-MO ESadek-MO linked an issue Mar 18, 2024 that may be closed by this pull request
Convert unit/util test files to pytest #5855
Closed
trexfeathers
trexfeathers requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb job, especially with so many files. Some useful patterns too.

A few pieces to change

lib/iris/tests/unit/util/test_column_slices_generator.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/util/test_equalise_attributes.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/util/test_file_is_newer_than.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/util/test_mask_cube.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/util/test_mask_cube.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (2e18ae8) to head (a4639ab).
Report is 14 commits behind head on FEATURE_pytest_conversion.

❗ Current head a4639ab differs from pull request most recent head f513b66. Consider uploading reports for the commit f513b66 to get more accurate results

Additional details and impacted files 
@@                      Coverage Diff                      @@
##           FEATURE_pytest_conversion    #5853      +/-   ##
=============================================================
- Coverage                      89.74%   89.74%   -0.01%     
=============================================================
  Files                             92       92              
  Lines                          22940    22940              
  Branches                        5462     5462              
=============================================================
- Hits                           20588    20587       -1     
- Misses                          1620     1621       +1     
  Partials                         732      732

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers merged commit 8ccb587 into SciTools:FEATURE_pytest_conversion Mar 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert unit/util test files to pytest
2 participants
@ESadek-MO @trexfeathers