Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted cube directory tests to pytest #5837

Merged
merged 11 commits into from
Mar 19, 2024
Merged

converted cube directory tests to pytest #5837

merged 11 commits into from
Mar 19, 2024

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Mar 14, 2024 •
edited by pp-mo
Loading

Addresses #5821

trexfeathers
trexfeathers requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked your working all the way through and these are comments are all I have ⭐

lib/iris/tests/unit/cube/test_Cube.py Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube.py Outdated Show resolved Hide resolved
@trexfeathers
Copy link
Contributor

Please remember to run ruff --select=PT lib/iris/tests/unit/cube/test_Cube.py before you are done

trexfeathers
trexfeathers requested changes Mar 15, 2024
View reviewed changes
lib/iris/tests/unit/cube/test_CubeAttrsDict.py Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube__operators.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube.py Outdated Show resolved Hide resolved
@ESadek-MO ESadek-MO changed the title converted asserts to pytest converted cube directory tests to pytest Mar 18, 2024
@ESadek-MO ESadek-MO linked an issue Mar 18, 2024 that may be closed by this pull request
Convert unit/cube test files to pytest #5821
Closed
@ESadek-MO ESadek-MO marked this pull request as ready for review March 18, 2024 15:02
trexfeathers
trexfeathers requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with every change you've made.

Just gave the files themselves the once-over and came up with these extra comments.

lib/iris/tests/unit/cube/test_Cube__operators.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_CubeList.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/cube/test_Cube__aggregated_by.py Outdated Show resolved Hide resolved
@trexfeathers trexfeathers merged commit dbc207e into SciTools:FEATURE_pytest_conversion Mar 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees
No one assigned
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert unit/cube test files to pytest
2 participants
@ESadek-MO @trexfeathers