-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy SUM with 1D weights sometimes fails #5083
Comments
I've confirmed this failure is still reproduced in the v3.4 release candidate. This is only a problem for the lazy case because in the real case Lines 3922 to 3932 in 57647d2
That said, if you pass your weights as a list in the real case, you get a failure here Line 3936 in 57647d2
Possibly we just need to use broadcast_to_shape before iris/lib/iris/analysis/__init__.py Line 1620 in 57647d2
|
Probably best to look at this AFTER the changes in #5084! |
Yes, definitely! I actually noticed this bug while writing tests for #5084 (it is still present after applying the changes from this PR). |
🐛 Bug Report
Collapsing a cube with lazy data using
iris.analysis.SUM
and 1D weightssometimes fails due to broadcasting errors:
How To Reproduce
Expected behaviour
No fail.
Environment
The text was updated successfully, but these errors were encountered: