Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset GHA cache_build #4814

Closed
bjlittle opened this issue Jun 17, 2022 · 4 comments
Closed

Reset GHA cache_build #4814

bjlittle opened this issue Jun 17, 2022 · 4 comments

Comments

@bjlittle
Copy link
Member

📰 Custom Issue

This isn't an automated process, so this issue is a reminder to reset the GHAs cache_build back to 0 when the cache_period is greater than 2022.12.

Where given a cache_period of YYYY.PP:

  • YYYY is the calendar year
  • PP is the week number of the year divided by 2 (currently)

The cache_period of 2022.13 should occur from Monday 27 June 2022.

Reference: See #4809

@trexfeathers
Copy link
Contributor

What's the value in cleaning this up? As far as I understand: it's just an arbitrary variable that allows us to 'kick the jukebox', with no intention that it means anything to developers. Can we not just leave it until we need it again?

Sorry if I've missed something.

@pp-mo
Copy link
Member

pp-mo commented Jun 20, 2022

What's the value in cleaning this up? As far as I understand: it's just an arbitrary variable that allows us to 'kick the jukebox', with no intention that it means anything to developers. Can we not just leave it until we need it again?

Sorry if I've missed something.

Yes I thought this too.
I thought we can just leave it at 'cache_build = 1', for as long as we like.
Or, anytime we want, we can set it back to 0, as long as other signature items have since changed.

?no?

@bjlittle
Copy link
Member Author

Sure, we absolutely could... I'm perhaps just being over-conscientious. Otherwise the cache_build just keeps getting bigger, and personally I'd prefer to see it only north of 0 by exception.

But, yeah, no harm, no foul.

@trexfeathers
Copy link
Contributor

personally I'd prefer to see it only north of 0 by exception

Whenever I need to change such a number and it's currently not 0 my instinct is always to see if I can set it back to 0 (i.e. make sure it hasn't yet been 0 in this cycle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants