Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system_test_grib_patch #2911

Closed
pelson opened this issue Nov 4, 2017 · 2 comments
Closed

Remove system_test_grib_patch #2911

pelson opened this issue Nov 4, 2017 · 2 comments
Labels
Experience: Low Good First Issue A good issue to take on if you're just getting started with Iris development Release: Patch

Comments

@pelson
Copy link
Member

pelson commented Nov 4, 2017

iris-grib may want to check this, but it doesn't belong in iris itself.

The offending test:

system_test_grib_patch (iris.tests.system_test.SystemInitialTest) ... SKIP: Test(s) require "iris-grib" package, which is not available.

https://github.com/SciTools/iris/blob/master/lib/iris/tests/system_test.py#L82
@trexfeathers trexfeathers added the Good First Issue A good issue to take on if you're just getting started with Iris development label Sep 25, 2020
@gcaria
Copy link
Contributor

gcaria commented Aug 13, 2021

I can't find this test on master, looks like this can be closed.

@rcomer
Copy link
Member

rcomer commented Aug 13, 2021

Thanks @gcaria, looks like this test was removed at #3662 👍

@rcomer rcomer closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Experience: Low Good First Issue A good issue to take on if you're just getting started with Iris development Release: Patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pelson @rcomer @trexfeathers @gcaria