Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when to specify parameter mappings and using default values #167

Open
isaacsas opened this issue Sep 29, 2022 · 2 comments
Open

when to specify parameter mappings and using default values #167

isaacsas opened this issue Sep 29, 2022 · 2 comments

Comments

@isaacsas
Copy link
Member

Right now it appears that default values for parameters get ignored during discretize. Similarly, one currently has to pass a parameter mapping to PDESystem giving the parameter values, which is not consistent with other ModelingToolkit system types (where such mappings are not required until problem creation time). I would propose making discretize require passing the parameter mapping, and for parameters not included in the mapping it should check if they have default values available (as done for other system/problem types).

@xtalax
Copy link
Member

xtalax commented Sep 30, 2022

@ChrisRackauckas @zoemcc Thoughts?

@isaacsas
Copy link
Member Author

As an alternative, perhaps structural simplification could be moved into symbolic_discretize, since that is still a symbolic component, and then users could be pointed to using that function that to get back an ODESystem or NonlinearSystem. That would give a closer workflow to other system types, as users could then directly pass these to ODEProblem / NonlinearProblem with ICs and/or parameter mappings as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants