Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method definition warning #153

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

ChrisRackauckas
Copy link
Member

Fixes #152

@ChrisRackauckas ChrisRackauckas merged commit 76ea2cc into master Mar 8, 2023
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch March 8, 2023 13:31
@KristofferC
Copy link

KristofferC commented Mar 8, 2023

I don't see how this solves anything 😕 . You still have two methods that only differ in their keyword arguments.

With master of package:

┌ Integrals [de52edbc-65ea-441a-8357-d3a637375a31]
│  WARNING: Method definition solve(SciMLBase.IntegralProblem{isinplace, P, F, L, U, K} where K where U where L where F where P where isinplace) in module Integrals at /home/kc/JuliaPkgs/Integrals.jl/src/Integrals.jl:60 overwritten at /home/kc/JuliaPkgs/Integrals.jl/src/Integrals.jl:111.
│    ** incremental compilation may be fatally broken for this module **
│  
│  WARNING: Method definition kwcall(Any, typeof(CommonSolve.solve), SciMLBase.IntegralProblem{isinplace, P, F, L, U, K} where K where U where L where F where P where isinplace) in module Integrals at /home/kc/JuliaPkgs/Integrals.jl/src/Integrals.jl:60 overwritten at /home/kc/JuliaPkgs/Integrals.jl/src/Integrals.jl:111.
│    ** incremental compilation may be fatally broken for this module **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method definition overwrite of solve(SciMLBase.IntegralProblem.
2 participants