From 3bbc879717a58efa9d1173b3d701e6f731ec0de4 Mon Sep 17 00:00:00 2001 From: Sam Verschueren Date: Tue, 13 Dec 2022 18:55:37 +0100 Subject: [PATCH 1/2] Do not decode + to a space - fixes #3 --- index.js | 2 -- readme.md | 1 - test.js | 6 +++--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/index.js b/index.js index 24e7db0..773ae6a 100644 --- a/index.js +++ b/index.js @@ -83,8 +83,6 @@ module.exports = function (encodedURI) { } try { - encodedURI = encodedURI.replace(/\+/g, ' '); - // Try the built in decoder first return decodeURIComponent(encodedURI); } catch (err) { diff --git a/readme.md b/readme.md index 3ed99b0..bd71b4b 100644 --- a/readme.md +++ b/readme.md @@ -7,7 +7,6 @@ ## Why? -- Decodes `+` to a space. - Converts the [BOM](https://en.wikipedia.org/wiki/Byte_order_mark) to a [replacement character](https://en.wikipedia.org/wiki/Specials_(Unicode_block)#Replacement_character) `�`. - Does not throw with invalid encoded input. - Decodes as much of the string as possible. diff --git a/test.js b/test.js index 86fabd5..0424493 100644 --- a/test.js +++ b/test.js @@ -3,8 +3,8 @@ import m from './'; const tests = { 'test': 'test', - 'a+b': 'a b', - 'a+b+c+d': 'a b c d', + 'a+b': 'a+b', + 'a+b+c+d': 'a+b+c+d', '=a': '=a', '%': '%', '%25': '%', @@ -20,7 +20,7 @@ const tests = { '%7 B%ab%%7C%de%%7 D': '%7 B%ab%|%de%%7 D', '%ab': '%ab', '%ab%ab%ab': '%ab%ab%ab', - '%61+%4d%4D': 'a MM', + '%61+%4d%4D': 'a+MM', '\uFEFFtest': '\uFEFFtest', '\uFEFF': '\uFEFF', '%EF%BB%BFtest': '\uFEFFtest', From 7268ef6b5bbe8a30b0fdcb0aae197c2aa7be8dd6 Mon Sep 17 00:00:00 2001 From: Sam Verschueren Date: Tue, 13 Dec 2022 18:59:20 +0100 Subject: [PATCH 2/2] 0.3.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e232823..0b1b750 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "decode-uri-component", - "version": "0.2.2", + "version": "0.3.0", "description": "A better decodeURIComponent", "license": "MIT", "repository": "SamVerschueren/decode-uri-component",