Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in HAL_IWDG_DEFAULT_TIMEOUT #4

Closed
Kira-sempai opened this issue Jun 29, 2021 · 5 comments
Closed

Bug in HAL_IWDG_DEFAULT_TIMEOUT #4

Kira-sempai opened this issue Jun 29, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Milestone

Comments

@Kira-sempai
Copy link

#define HAL_IWDG_DEFAULT_TIMEOUT (((6UL * 256UL * 1000UL) / LSI_VALUE) + ((LSI_STARTUP_TIME / 1000UL) + 1UL))

Probably should be
#define HAL_IWDG_DEFAULT_TIMEOUT (((6UL * 256UL * 1000UL) / LSI_VALUE) + ((LSI_STARTUP_TIMEOUT / 1000UL) + 1UL))

@Kira-sempai
Copy link
Author

BTW, can't find it's definition in stm32f2xx_hal_conf_template.h

@RKOUSTM RKOUSTM self-assigned this Jul 13, 2021
@RKOUSTM RKOUSTM added hal HAL-LL driver-related issue or pull-request. enhancement New feature or request labels Jul 13, 2021
@RKOUSTM
Copy link
Contributor

RKOUSTM commented Jul 29, 2021

Hi @Kira-sempai,

Thank you for this report. It has been transferred to our development teams. We will be back to you as soon as we get an answer.

With regards,

@RKOUSTM RKOUSTM added documentation Issue related to documentation found in comments whithin source files. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system and removed hal HAL-LL driver-related issue or pull-request. labels Aug 13, 2021
@RKOUSTM
Copy link
Contributor

RKOUSTM commented Aug 13, 2021

Hi @Kira-sempai,

Thank you for your contribution. The point you reported is related to a typo in the comment description. Indeed, a fix in the comment below :

The timeout value is multiplied by 1000 to be converted in milliseconds.
LSI startup time is also considered here by adding LSI_STARTUP_TIMEOUT
converted in milliseconds. */

will be updated and made available in future release looks like the following:

  The timeout value is multiplied by 1000 to be converted in milliseconds.
- LSI startup time is also considered here by adding LSI_STARTUP_TIMEOUT
+ LSI startup time is also considered here by adding LSI_STARTUP_TIME
   converted in milliseconds. 

Concerning the define of the LSI_STARTUP_TIME, you can find it in the include files of the CMSIS device.

Thank you once again for your contribution.

With regards,

@RKOUSTM
Copy link
Contributor

RKOUSTM commented Aug 13, 2021

ST Internal Reference: 111928

@RKOUSTM RKOUSTM added this to the v1.9.4 milestone Dec 8, 2021
@TOUNSTM
Copy link
Contributor

TOUNSTM commented Apr 28, 2023

Hello @Kira-sempai,

The fix has been implemented and is now available in the frame of the latest STM32CubeF2 package V1.9.4 release. This issue can be closed now. Thank you again for your contribution.

With Regards,

@TOUNSTM TOUNSTM closed this as completed Apr 28, 2023
@ALABSTM ALABSTM added hal HAL-LL driver-related issue or pull-request. and removed documentation Issue related to documentation found in comments whithin source files. labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Projects
None yet
Development

No branches or pull requests

4 participants