Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced ) brace in defines #1

Closed
salkinium opened this issue Jun 4, 2019 · 4 comments
Closed

Misplaced ) brace in defines #1

salkinium opened this issue Jun 4, 2019 · 4 comments
Assignees
@ALABSTM
Labels
bug Something isn't working cmsis CMSIS-related issue or pull-request. spotted before customer Spotted and fixed internally before being pointed out by users but not published yet
Projects
stm32cube-mcu-fw-dashboard
Milestone
v1.8.0

Comments

@salkinium
Copy link

salkinium commented Jun 4, 2019 •
edited
Loading

Describe the set-up

  • arm-none-eabi-gcc
  • #include <stm32f2xx.h>

Describe the bug

The SYSCFG_EXTICR1_EXTI* defines sometimes contain a trailing ).

#define SYSCFG_EXTICR3_EXTI9_PF         0x00000050)                            /*!<PF[9] pin */

How To Reproduce
Try to use SYSCFG_EXTICR3_EXTI9_PF without causing a syntax error.

Additional context

These are a lot of mistakes, so see the full patch.
@CCASTM
Copy link
Contributor

CCASTM commented Jun 5, 2019

Hello Salkinium,
Thank you for your finding, we have missed this syntax errors.
The correction is obvious, you can update on your side
We will provide the updated code in our next publication @KORKAD
Regards
Christophe

@CCASTM
Copy link
Contributor

CCASTM commented Jun 5, 2019 •
edited by ALABSTM
Loading

ST Internal Reference: 67748

@CCASTM
Copy link
Contributor

CCASTM commented Jun 5, 2019

adding Ali in the thread @ALABSTM

@ALABSTM ALABSTM self-assigned this Jun 10, 2019
@ALABSTM ALABSTM added the bug Something isn't working label Jun 12, 2019
@ALABSTM
Copy link
Contributor

ALABSTM commented Jun 17, 2019

Hi Salkinium,

Thank you once more for your contribution. Actually we already identified this issue and corrected it. It will be available in our next release, i.e. v1.8.0.

With regards

@ALABSTM ALABSTM closed this as completed Jun 17, 2019
@ALABSTM ALABSTM added spotted before customer Spotted and fixed internally before being pointed out by users but not published yet internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system labels Nov 28, 2019
@ALABSTM ALABSTM removed the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Sep 16, 2020
@ALABSTM ALABSTM added the cmsis CMSIS-related issue or pull-request. label Oct 12, 2020
@ALABSTM ALABSTM added this to the v1.8.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ALABSTM ALABSTM

Labels
bug Something isn't working cmsis CMSIS-related issue or pull-request. spotted before customer Spotted and fixed internally before being pointed out by users but not published yet
Projects
stm32cube-mcu-fw-dashboard
  
Done
Milestone
v1.8.0
Development

No branches or pull requests
3 participants
@salkinium @CCASTM @ALABSTM