-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date support #888
Comments
Some findings:
Some ideas:
Unlike what we did with SRG Media Player, though, we should not hack date support if the stream does not support it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 14 days or if the stale label is not removed. |
Seek to date APIWe will expose the simple Implementing tolerances would require using a fixed date vs. time reference, with no guarantee it remains valid in time, and would introduce a lot of complexity (e.g. time ranges should be expressible with either dates or positions, like we did in SRG Media Player). This complexity does not seem justified yet. In general, if one wants to seek to some date, it is always as a result of having some external date information available to perform a single seek. Other seeks (e.g. to implement a progress bar or skip buttons) are probably always time-based anyway. If Blocked time range and smooth seeking supportSince we do not call our seek API but rather This means we could theoretically start playback in a on-demand or livestream in a paused state while seeing a forbidden image, but this is really a corner case which, to be addressed correctly, would require a lot of work. Playback startTo be able to start playback at a specific date we would need to update For this reason we decided not to support playback start at a specific date for the moment. This keeps things simple until this feature is really requested, at which point we might decide what to do. Date calculationsUnlike Letterbox which was able to calculate date estimeates for livestreams based on wall-clock playback, Pillarbox only delivers date values and supports seeking to a date when a stream contains timestamps. Moreover, Letterbox was correcting fluctuations near the live edge by storing a time vs. date reference. This is actually not needed and was an artifact of time truncation to the seekable time range, a behavior also implemented by Pillarbox but that we now have removed. No |
As a developer integrating Pillarbox I want to be able to seek to a specific date, provided such information is returned in a stream.
Acceptance criteria
Hints
Tasks
AVPlayer
APIs).ProgressTracker
.func
but we sometimes usevar
).Check that we can start playback at some date (make dedicated API available if needed).The text was updated successfully, but these errors were encountered: