Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo accessibility with VoiceOver #578

Open
2 tasks
defagos opened this issue Sep 27, 2023 · 3 comments
Open
2 tasks

Demo accessibility with VoiceOver #578

defagos opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@defagos
Copy link
Member

defagos commented Sep 27, 2023

As a user requiring accessibility features I would like to be able to use the Pillarbox demo application with VoiceOver. As a developer integrating Pillarbox I would like to have a good example of how player accessibility can be implemented.

Acceptance criteria

  • The application can be used with VoiceOver.
  • Demo players can be used with VoiceOver.

Tasks

  • Add VoiceOver support to demo players.
  • Ensure the demo application can be navigated with VoiceOver (e.g. escape gesture also on iPad).
@defagos defagos changed the title Demo player accessibility Demo player accessibility with VoiceOver Sep 27, 2023
@defagos defagos changed the title Demo player accessibility with VoiceOver Demo accessibility with VoiceOver Sep 27, 2023
@defagos defagos added the enhancement New feature or request label Oct 6, 2023
Copy link

github-actions bot commented Jan 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 14 days or if the stale label is not removed.

@github-actions github-actions bot added the stale This was not recently worked on label Jan 5, 2024
Copy link

This issue has been automatically closed because it has not had recent activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@defagos
Copy link
Member Author

defagos commented Apr 20, 2024

We should have the standard slider pose as ours in our custom demo:

.accessibilityRepresentation {
    Slider(progressTracker: progressTracker)
}

(possibly with other modifiers to announce changes during seeks, check how the system UI works), but sadly using the slider this way works but leads to a resource leak. It is likely an issue we should report to Apple.

Otherwise our custom player UI is pretty much already accessible, thanks to the use of SF Symbols.

@defagos defagos reopened this Apr 20, 2024
@github-actions github-actions bot removed the stale This was not recently worked on label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant