Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

never configure leverArmX,leverArmY,leverArmZ in ConfigApplier::configureImuAlignement method #27

Open
pierreopti opened this issue May 20, 2024 · 0 comments
Assignees

Comments

@pierreopti
Copy link

pierreopti commented May 20, 2024

Section imuAlignementLeverArm:
# X Primary lever arm in IMU X axis (once IMU alignment is applied) m
leverArmX: xxxx
# Y Primary lever arm in IMU Y axis (once IMU alignment is applied) m
leverArmY: yyyy
# Z Primary lever arm in IMU Z axis (once IMU alignment is applied) m
leverArmZ: zzzz

Theses 3 parameters are not taken and applied from configuration file.
The function ConfigApplier::configureImuAlignement get parameters from device , compare with new parameters and set the device parameter with the call sbgEComCmdSensorSetAlignmentAndLeverArm.
But this call is done with geted parameters not with new parameters.

Suggested change of config_applier.cpp is :

@@ -130,7 +130,7 @@ void ConfigApplier::configureImuAlignement(const SbgEComSensorAlignmentInfo& ref
   || !areEquals(sensor_alignement.misPitch, ref_sensor_align.misPitch)
   || !areEquals(sensor_alignement.misYaw, ref_sensor_align.misYaw))
   {
-    error_code = sbgEComCmdSensorSetAlignmentAndLeverArm(&m_ref_sbg_com_handle, &ref_sensor_align, level_arms_vector.data());
+    error_code = sbgEComCmdSensorSetAlignmentAndLeverArm(&m_ref_sbg_com_handle, &ref_sensor_align, ref_level_arms.data());
 
     checkConfigurationApplied(error_code, std::string("IMU alignement"));
   }
@pierreopti pierreopti changed the title never configure secondary Lever arm in ConfigApplier::configureImuAlignement method never configure leverArmX,leverArmY,leverArmZ in ConfigApplier::configureImuAlignement method May 21, 2024
@cledant cledant self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants