Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending CMake build configurations #2

Open
vovo-4K opened this issue Feb 22, 2022 · 2 comments
Open

Extending CMake build configurations #2

vovo-4K opened this issue Feb 22, 2022 · 2 comments
Assignees

Comments

@vovo-4K
Copy link

vovo-4K commented Feb 22, 2022

Hello! It's great to see sbgECom in the public repository. This will make using the library much easier in the CI pipeline.

I'm using sbgECom as a dependency using CMake add_directory() command.
It would be great if some build options will be added like:

  • building sbgECom as a shared library
  • building sbgECom as a static library
  • turning off examples building

like:

option(BUILD_SBGECOM_SHARED "Build sbgECom shared" OFF)
option(BUILD_SBGECOM_STATIC "Build sbgECom static" ON)
option(BUILD_SBGECOM_EXAMPLES "Build examples" ON)

#...
if (BUILD_SBGECOM_SHARED)
	add_library(sbgECom SHARED ${SRC} ${COMMON_SRC})
endif()
if (BUILD_SBGECOM_STATIC)
	add_library(sbgECom STATIC ${SRC} ${COMMON_SRC})
endif()
#...

if (BUILD_EXAMPLES)
	# Add all examples
#...
endif()
@rsiryani
Copy link
Contributor

Hi,

Thanks for the feedback.
We are indeed also using this type of conditional build options internally.
We haven't included it in the public sbgECom SDK for the sake of simplicity.

However, we can definitely add it.
By the way are you using Conan for your CI pipeline or not at all?
Thanks,

@vovo-4K
Copy link
Author

vovo-4K commented Feb 25, 2022

It would be great!
Yes, I use Conan as a dependency manager. I don't use Artifactory yet so for libraries which is not present in the Conan Center, the git submodules approach is used.
If the sbgECom will have a Conan recipe or will appear at Conan Center it also would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants