-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing types for sap.ui.qunit.utils.nextUIUpdate and waitForThemeApplied #459
Comments
I'm not sure if I got your point regarding the two APIs at the end:
In general, it was a conscious decision so far to not make the testing helpers ( |
I'd really like these two functions, they fill the exact spot that the test for my small custom control needs. |
I don't think there is any issue in the dts generator, right? The types not being marked as public in the OpenUI5 sources is nothing that can be changed in the generator. After all you explicitly wrote "the two modules are also missing from ui5.sap.com's documentation", which is not a result of this generator. As far as I see everything is about the annotations in the original UI5 code. So please open an issue in the OpenUI5 repo to get the officially recommended replacements actually usable. |
|
Ok, I'll check. |
@akudev As you might remember, we've excluded It's done here: https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/ui/core/.library#L125. |
I've opened SAP/openui5#4074 as suggested :) |
Right. But regardless, at this point I don't see anything that needs to be done within the |
Describe the bug
I want to use sap.ui.qunit.utils.nextUIUpdate and waitForThemeApplied as replacements for deprecated Core APIs, as advertised by the ui5linter. However,
@sapui5/types
is missing the modules -- perhaps because it contains neither asap.ui.d.ts
nor asap.ui.qunit.d.ts
. Thus, when importingimport nextUIUpdate from "sap/ui/qunit/utils/nextUIUpdate";
, and error message appears: "Cannot find module 'sap/ui/qunit/utils/nextUIUpdate' or its corresponding type declarations.ts(2307)"".Expected behavior
Correctly typed APIs are available.
Workaround
Manually place a definition file in the project:
Additional context
It might be worth to doublecheck the type definitions when adding the module to the distribution:
@public
annotationNote that the two modules are also missing from ui5.sap.com's documentation
The text was updated successfully, but these errors were encountered: