Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.ushell.Container removed in 1.100? #347

Open
DetachHead opened this issue Mar 24, 2022 · 4 comments
Open

sap.ushell.Container removed in 1.100? #347

DetachHead opened this issue Mar 24, 2022 · 4 comments

Comments

@DetachHead
Copy link

the sap.ushell.Container const that was defined in sap.ushell.d.ts seems to no longer be present in version 1.100. how come it was removed?

@codeworrior
Copy link
Member

@aschmalzhaf can you please take a look and comment? Did only the global name disappear and it's possible now to access sap.ushell.Container via a module export in UI5 1.100?

@aschmalzhaf
Copy link

The issue should be fixed with newer UI5 versions (1.102++ should work fine).
Please excuse all inconveniences.

@akudev
Copy link
Contributor

akudev commented May 30, 2022

Hold on... I don't think so.

It appears as a class at https://ui5.sap.com/1.101.0/#/api/sap.ushell.Container, but loaded from module "sap/ushell/Container".
In 1.99 it used to be a field on the namespace (https://ui5.sap.com/1.99.0/#/api/sap.ushell), which it isn't anymore.

So it's sort of back again after disappearing in 1.100, but not like it used to be.
A question to @DetachHead would be whether it would be acceptable to import it from module "sap/ushell/Container" instead of addressing it as a global - and whether this works at all, giving access to the singleton instance.

Edit: a quick test seems to show that the class is imported, not the singleton instance.

@akudev
Copy link
Contributor

akudev commented Aug 1, 2022

Now internally tracked as 2280149651 to get it handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants