Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.m.upload.FilePreviewDialog doesn't show preview for mimetype image/jpg #4061

Open
geert-janklaps opened this issue Jun 7, 2024 · 1 comment

Comments

@geert-janklaps
Copy link

OpenUI5 version: 1.24.1

Browser/version (+device/version): Microsoft Edge, Google Chrome, Safari

Any other tested browsers/devices(OK/FAIL): Windows, Iphone

Steps to reproduce the problem:
Currently the file preview dialog doesn't preview a jpg files if the mimetype is set to image/jpg, because the expected mimetype for a jpg file is image/jpeg. (hardcoded in the FilePreviewDialog, see referenced line below)
Some systems set the mimetype for a jpg file to image/jpg (for example SAP Service Cloud).

const PreviewableMediaType = {

What is the expected result?
A preview to be show if the mimetype is image/jpg (same as image/jpeg)

What happens instead?
The file preview not available placeholder is shown

@TeodorTaushanov
Copy link
Member

Hi,

Could you guide us through the steps on how to recreate it?

Best,
Teo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants