-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right click fires other events #3973
Comments
The issue is not relevant to Windows users but seems to be only related to the macOS specific behavior that allows users opening the context menu with the control + left click combination: https://support.apple.com/guide/mac-help/right-click-mh35853/mac
I'm not able to reproduce the behavior neither with nor without the control key. Tried with the custom minesweeper button, Demo Kit sample button, and the plain HTML button on macOS. Is the button issue still valid? Other cases such as the IconTabBar can be still reproduced on macOS but only with the combination control + left click. Since there are other ways to open context menus, and since opening a context menu with the combination is a macOS-only feature, I wonder to which extend the described issue is really relevant to users of the affected controls. |
Hi @boghyon |
Regarding second part of your comment: |
Just interesting observation: https://openui5.hana.ondemand.com |
Which macOS version are you testing with? Which options for the "Secondary click" are set in your system? Without holding the Control key pressed, try with:
Just checked; not reproducible with Shift+F10 either.
Yes, ui5.sap.com or sapui5.hana.ondemand.com currently responds with SAPUI5 1.120.6 (built at 03.02.2024 17:13:00). The change ce99a79 is available since 1.121 so far. |
hi @boghyon. I'm using macbook touchpad only with ctrl + click or just right click from touchpad (in my settings it's pressing by two fingers at one time) to fire right click. Probably soon I will be able to check on Windows as well. Then I let you know. |
Yep, seems on Windows it's working fine with my custom button. |
Hello @harelyshau , |
Hey @harelyshau, The fix is available now on master (linked above) and will be coming to release version 1.129. Thanks, |
This is copy of this issue: #3936 as I didn't get any response there. Might be helpful to read it initially.
OpenUI5 version: latest (1.120.7)
Browser/version (+device/version): Chrome, Firefox, Safari (all on MacOS)
URL (minimal example if possible):
https://harelyshau.dev/#/minesweeper (most priority for me)
https://openui5.hana.ondemand.com/entity/sap.m.IconTabBar/sample/sap.m.sample.IconTabBar
https://openui5.hana.ondemand.com/entity/sap.tnt.ToolHeader/sample/sap.tnt.sample.ToolHeaderIconTabHeader
Steps to reproduce the problem:
For custom button:
For IconTab:
IconTabFilter (1st link)
IconTabHeader (2nd link)
I'm using right click and left click with pressed ctrl button (should be the same result, but might be different)
And you will see that time to time events like select or liveChange are triggered by this scenario
Video link:
https://1drv.ms/v/s!AhK9R225yn15a94Enfuo3KDccoI?e=VvVR2Q
What is the expected result?
Just open context menu without triggering extra events
What happens instead?
Context menu is opened but with extra triggering of events
Any other information? (attach screenshot if possible)
I've found that when I implemented custom button this way (just add one more event for handling right click). And I found that right click also triggers simple press event in button. I didn't expect that and tried with default button and there I wasn't be able to reproduce it and found other controls which have similar issue. Seems it's not all controls which have this behaviour but it's what I found quickly
image
Video link: https://1drv.ms/v/s!AhK9R225yn15a94Enfuo3KDccoI?e=VvVR2Q
The text was updated successfully, but these errors were encountered: