generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE - Fiori preview middleware #971
Labels
Comments
5 tasks
This was referenced Jul 10, 2023
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a developer,
I want to preview my Fiori applications and adaptation projects locally in an FLP sandbox without having to maintain test files locally,
so that I don't have to worry about changes of these files in the future.
Description
The functionality available in the
@sap/ux-ui5-tooling
preview middleware (https://www.npmjs.com/package/@sap/ux-ui5-tooling#4-preview) is to be published to open source. It then needs to be extended not only be usable for variant creation but the simple preview with a sandbox FLP. As result, it is not necessary anymore to generate thetest/flpSandbox.html
, consequently, we can easily update it (through the middleware) with default them or other best practices.Additionally, the published preview middleware needs to handle adaptation projects, so that a developer used to Fiori app development gets the same experienced when developing a Fiori adaptation project.
Technical Design
axios-extension
manifest.json
based on an app descriptor variant fileui5-proxy-middleware
manifest.json
in the project to determine the ui5 versionfiori-preview-middleware (new module)
Acceptance Criteria
GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)
Given I have a Fiori application project with a ui5.yaml configured with the new middleware (and no html files for testing)
when I execute
ui5 serve
then a sandboxed FLP opens with my local app running in it.
Given I have a Fiori adaptation project with a ui5.yaml with the new middleware properly configured for adaptation projects (and no html files for testing)
when I execute
ui5 serve
then a sandboxed FLP opens with my local adaptation project merged with the reference app running in it.
Given I need to add project specific code to my FLP sandbox
when I execute a command to eject the
flpSandbox.html
then an
flpSandbox.html
file is added to my project and I can modify it for my needs.Notes
Since the requested feature is quite complex and combines existing functionality from different modules, it needs to be sequentially implemented and released.
Tasks
@sap/ux-ui5-tooling
and make it better configurable (v0.1) - Initial publication of the preview middleware #1093@sap/ux-ui5-tooling
with preconfigured parameters ensuring the compatibility with existing projects (SAP Internal)@sap/ux-ui5-tooling
(SAP internal)test/flpSandbox.html
into the project folder so that developers can also modified it for special use cases (Feature: (1) list virtual preview files and (2) eject virtual files on request #2062)fiori-*-writers
in theopen-ux-tools
to not generate thetest/flpSandbox.html
anymore and add the preview middleware to theui5*.yaml
files (v0.3)cds-plugin-ui5
to handle virtual files served with thepreview-middleware
([cds-plugin-ui5] How to show virtual html links? ui5-community/ui5-ecosystem-showcase#785)The text was updated successfully, but these errors were encountered: