Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization / integrate savvy package #272

Open
jdherman opened this issue Nov 7, 2019 · 2 comments
Open

Visualization / integrate savvy package #272

jdherman opened this issue Nov 7, 2019 · 2 comments

Comments

@jdherman
Copy link
Member

jdherman commented Nov 7, 2019

Currently we have limited plotting features:
https://github.com/SALib/SALib/tree/master/src/SALib/plotting

I used to be concerned about adding dependencies, but I think it could be valuable to have more plotting functions inside the library as we think about v2.0. Especially for standard plot styles used for sensitivity indices.

Two (maybe more) ideas here:

  1. Because indices can now be stored as pandas dataframes, we can extend pandas plotting functions. An example is the bar plot created by @ConnectedSystems
    https://github.com/SALib/SALib/blob/master/src/SALib/plotting/bar.py

where the usage is Si_df.plot(kind='...' ...).
(this might coincide with making dataframes the default return type)

  1. The coolest SA visualizations I've seen are in savvy:
    https://github.com/houghb/savvy

It looks like this hasn't been updated in a while. I wonder if we could absorb some of the plot styles into the SALib.plotting module, if it's ok with @houghb .

The potential downside would be adding dependencies to some of the network plotting libraries, which in my experience have some issues with cross-platform compatibility. Maybe these could be optional to avoid breaking the installation.

Ideally the plots can apply to as many of the SA methods as possible. In general I don't see a reason to restrict this if there's interest.

@houghb
Copy link

houghb commented Nov 8, 2019

You're welcome to copy any of the plot styles and code from savvy that you'd like @jdherman, as you said I haven't updated that in a long time and don't have time to do so now (it is probably several major versions of all packages behind). Those visualizations were very helpful for me and I hope they can be repurposed to help others!

@willu47
Copy link
Member

willu47 commented Nov 8, 2019

@houghb - if you're not actively maintaining savvy any more, perhaps you could consider transferring the repository to the SALib organisation - we could then gradually migrate your visualisation code into SALib, or keep savvy as a sub-package of the SALib library? Then you'd effectively become an SALib author!

I'd prefer not to manually copy (duplicate) code where possible, rather to import the functionality from the savvy library into SALib.

There are various options of course - more or less disruptive, but it would be nice to have the SALib family of tools together in one place.

@jdherman jdherman moved this from Features to v2.0 in SALib Development Roadmap Nov 11, 2019
@jdherman jdherman changed the title Visualization Visualization / integrate savvy package Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants