Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated Map Constructors #323

Open
S010MON opened this issue May 16, 2022 · 1 comment
Open

Depreciated Map Constructors #323

S010MON opened this issue May 16, 2022 · 1 comment
Assignees
Labels
LOW Low priority feature that is merely nice to have Lvl 4 ~4 - 8hrs task refactor Rewrite exisiting code

Comments

@S010MON
Copy link
Owner

S010MON commented May 16, 2022

DirectionFollowAgentTest @Jolijn2020
RayFeedbackTest @MatthewFoster02
WallFollowAgentTest @laurajogi

These tests all use a constructor for the map that is causing significant tech debt. This constructor will be depreciated in phase 3 and these tests will need to be rewritten properly.

Note, some of you are using global variables in multiple tests. This can cause dependency issues due to the asynchronous nature of the Juinit runner. Each test should run in complete isolation, to set up a test environment multiple times, an @BeforeAll and @AfterAll tag can be used to construct and destruct the environment.

@S010MON S010MON added refactor Rewrite exisiting code LOW Low priority feature that is merely nice to have Lvl 4 ~4 - 8hrs task labels May 16, 2022
@S010MON S010MON changed the title Remove map constructors that do not use settings Depreciated Map Constructors May 16, 2022
@Jolijn2020
Copy link
Collaborator

DirectionFollowAgentTest is fixed in branch 323-depreciated-map-constructors

(RayFeedbackTest too)

@Jolijn2020 Jolijn2020 reopened this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LOW Low priority feature that is merely nice to have Lvl 4 ~4 - 8hrs task refactor Rewrite exisiting code
Projects
None yet
Development

No branches or pull requests

4 participants