Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Docker image for AWS #463

Closed
marco-brandizi opened this issue Oct 22, 2019 · 0 comments
Closed

Separate Docker image for AWS #463

marco-brandizi opened this issue Oct 22, 2019 · 0 comments

Comments

@marco-brandizi
Copy link
Member

Currently, the Knetminer's Docker image embeds features that are required under AWS, for instance for the purpose of sending analytics logs to an S3 store.

We need more modularity, ie, a new image (eg, Dockerfile-aws) that is based on the existing one and has the additional components. The AWS-specific conditional code (eg, in runtime-helper.sh) can remain, proper checking makes it working when outside of Amazon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant