Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date input should support JDay based date inputs #434

Closed
QGerrit opened this issue Jun 6, 2022 · 5 comments
Closed

Date input should support JDay based date inputs #434

QGerrit opened this issue Jun 6, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request. These should be converted into discussions.

Comments

@QGerrit
Copy link
Contributor

QGerrit commented Jun 6, 2022

Feature request:

Before Astro supported datetime-local as a type of input, my team built a date input picker based on JDay for choosing the date.

image

Now that datetime-local is supported, we'd really like to switch to using that, but our users are accustomed to dealing with JDay values rather than month/day when copying dates from an email. Is a JDay based date input on the horizon somewhere?

@micahjones13 micahjones13 added the enhancement New feature or request. These should be converted into discussions. label Jun 6, 2022
@micahjones13 micahjones13 self-assigned this Jun 6, 2022
@micahjones13
Copy link
Collaborator

I've created a ticket and we will look into adding this. I'll post here with updates when I have them. Thanks for bringing this up!

@micahjones13
Copy link
Collaborator

Hey @QGerrit, sorry for the delay on this. I have some clarifying questions for you:

  • Is what you're looking for an input that is essentially datetime-local, but uses the JDay instead of MM/DD/YYYY? Or are you looking for something like the second input in your example, one that just holds the JDay?
  • Would you expect the calendar date-picker UI to pop up for JDay selections as well?

@QGerrit
Copy link
Contributor Author

QGerrit commented Jul 19, 2022

  1. Yes, that's exactly what I was hoping for, we went for multiple inputs when building one for simplicity, but an input with a placeholder of JJJ YYYY (YYYY JJJ?) would be nicer from a user experience I think.
  2. Ideally, yes. It might not be used all the time, but is very convenient!

@micahjones13
Copy link
Collaborator

Hey @QGerrit got some more clarifying questions for you -

  • What type of value would you expect when this input is submitted? The JDay, or MM/DD/YYYY value converted from the JDay? Something else?

@QGerrit
Copy link
Contributor Author

QGerrit commented Aug 4, 2022

Since that's purely display information, it seems like it would be best to preserve the same output format as the normal datetime input... however, it doesn't actually matter much to me, since we're grabbing the value and parsing it into an integer (epoch time) to be stored in the database.

@RocketCommunicationsInc RocketCommunicationsInc locked and limited conversation to collaborators Oct 31, 2022
@micahjones13 micahjones13 converted this issue into discussion #867 Oct 31, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request. These should be converted into discussions.
Projects
None yet
Development

No branches or pull requests

2 participants