Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a message-content slot within rux-modal #398

Closed
QGerrit opened this issue May 11, 2022 · 4 comments · Fixed by #413
Closed

Support a message-content slot within rux-modal #398

QGerrit opened this issue May 11, 2022 · 4 comments · Fixed by #413
Assignees
Labels
enhancement New feature or request. These should be converted into discussions.

Comments

@QGerrit
Copy link
Contributor

QGerrit commented May 11, 2022

Currently, a <rux-modal> element has a modal-message attribute which sets the message. This is very convenient for simple modals, but sometimes it would be nice to be able to include rich content (e.g. a link to help documentation with more details). Ideally, this should be achievable via a custom slot. Thoughts?

@markacianfrani
Copy link
Collaborator

Absolutely! We've actually already done this and reworked modal to be entirely composable with slots. Unfortunately, it's a breaking change so it's currently in our 7.0 next branch. We'll be releasing a new beta tomorrow. We're going to revisit backporting this change to 6.0 in the meantime because the current modal implementation isn't very flexible.

@QGerrit
Copy link
Contributor Author

QGerrit commented May 11, 2022

That's awesome, thank you @markacianfrani!

@micahjones13 micahjones13 self-assigned this May 20, 2022
@micahjones13 micahjones13 added the enhancement New feature or request. These should be converted into discussions. label May 20, 2022
@micahjones13 micahjones13 linked a pull request May 20, 2022 that will close this issue
7 tasks
@micahjones13
Copy link
Collaborator

Hey @QGerrit, just wanted to check in and say that a re-work of modal has just been merged to main that contains the option to use slots for all of the modal's parts, so you can customize it as much as you want. This will be released tomorrow in the latest version (6.8).
Hopefully this helps, and if you have any questions please reach out again!

@QGerrit
Copy link
Contributor Author

QGerrit commented May 31, 2022

Awesome, thank you @micahjones13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. These should be converted into discussions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants