-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a message-content slot within rux-modal #398
Comments
Absolutely! We've actually already done this and reworked modal to be entirely composable with slots. Unfortunately, it's a breaking change so it's currently in our 7.0 next branch. We'll be releasing a new beta tomorrow. We're going to revisit backporting this change to 6.0 in the meantime because the current modal implementation isn't very flexible. |
That's awesome, thank you @markacianfrani! |
Hey @QGerrit, just wanted to check in and say that a re-work of modal has just been merged to main that contains the option to use slots for all of the modal's parts, so you can customize it as much as you want. This will be released tomorrow in the latest version (6.8). |
Awesome, thank you @micahjones13! |
Currently, a
<rux-modal>
element has amodal-message
attribute which sets the message. This is very convenient for simple modals, but sometimes it would be nice to be able to include rich content (e.g. a link to help documentation with more details). Ideally, this should be achievable via a custom slot. Thoughts?The text was updated successfully, but these errors were encountered: