Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Status feature [experimental] #5

Closed
kenny-y opened this issue Dec 21, 2017 · 3 comments · Fixed by #135
Closed

Add Status feature [experimental] #5

kenny-y opened this issue Dec 21, 2017 · 3 comments · Fixed by #135
Labels
feature

Comments

@kenny-y
Copy link
Member

kenny-y commented Dec 21, 2017

  • op: set_level - one of 'info', 'warning', 'error', or 'none'
  • op: status - status message [experimental]
@kenny-y kenny-y changed the title Add Status feature Add Status feature [experimental] Dec 21, 2017
@minggangw
Copy link
Member

I think we have implemented this feature already, please @qiuzhong confirm it, thanks!

@qiuzhong
Copy link
Collaborator

@minggangw , set_level has been implemented but I didn't see there is any status operation branch in the code.

@minggangw
Copy link
Member

Oh, I misunderstood the op here. We only implemented the set_level, so let's just mark the set_level as DONE.

@smartin015 smartin015 mentioned this issue Mar 21, 2020
Merged
minggangw pushed a commit that referenced this issue Mar 22, 2020
@smartin015
Add set_level and status to bridge (#135)
59163ba 
Prior to this PR, the bridge returned "set_level" in response to requests - this doesn't match the protocol spec which claims set_level is a request to set the reporting level, not a response.

This PR makes the bridge return actual status responses, and suppresses status messages below a level configurable with the set_level message. I also updated the error cases to forward the actual messages instead of just using debug(), and added a command-line flag to set the starting status level (for testing and/or other scripting).

Fixes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add set_level and status to bridge smartin015/ros2-web-bridge
3 participants
@kenny-y @minggangw @qiuzhong