Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy testing improvements #11

Open
feed3r opened this issue Jul 3, 2022 · 0 comments
Open

Proxy testing improvements #11

feed3r opened this issue Jul 3, 2022 · 0 comments

Comments

@feed3r
Copy link
Member

feed3r commented Jul 3, 2022

in brainclient/brainClient.go

```

detailsEndpoint string
}

func NewClient(brainAddr string, indicatorsEndpoint string, detailsEndpoint string) *Client {


I'm just thinking, not sure about it: maybe we can return *BrainClient instead of *Client? In java i might return the interface instead that the concrete type. But it depends why there is here an interface (so maybe both ways can be ok).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant