From 302e776f41e08c80de9e2548f7925f2a6de93e66 Mon Sep 17 00:00:00 2001 From: Asaad Mahmood Date: Fri, 12 Jul 2019 04:30:26 +0500 Subject: [PATCH] MM-16044 - Updating radio buttons (a11y) (#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test --- .../__snapshots__/expand_view.test.jsx.snap | 22 +- .../components/expand_view.jsx | 20 +- .../new_channel_modal.test.jsx.snap | 69 +-- .../new_channel_modal/new_channel_modal.jsx | 11 +- .../team_general_tab/team_general_tab.jsx | 7 +- .../join_leave_section.test.jsx.snap | 9 +- .../join_leave_section/join_leave_section.jsx | 7 +- .../advanced/user_settings_advanced.jsx | 7 +- ...esktop_notification_settings.test.jsx.snap | 481 +++++++++--------- .../manage_auto_responder.test.jsx.snap | 14 +- .../desktop_notification_settings.jsx | 149 +++--- .../email_notification_setting.test.jsx.snap | 83 +-- .../email_notification_setting.jsx | 15 +- .../notifications/manage_auto_responder.jsx | 6 +- .../user_settings_notifications.jsx | 36 +- .../user_settings_sidebar.test.jsx.snap | 2 +- .../sidebar/user_settings_sidebar.jsx | 49 +- sass/layout/_forms.scss | 7 + 18 files changed, 487 insertions(+), 507 deletions(-) diff --git a/components/channel_notifications_modal/components/__snapshots__/expand_view.test.jsx.snap b/components/channel_notifications_modal/components/__snapshots__/expand_view.test.jsx.snap index 91b46bb69766..82ac8b1ecb35 100644 --- a/components/channel_notifications_modal/components/__snapshots__/expand_view.test.jsx.snap +++ b/components/channel_notifications_modal/components/__snapshots__/expand_view.test.jsx.snap @@ -12,7 +12,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot inputs={ Array [
-
+
@@ -22,6 +22,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot
-
+
, ] } @@ -117,7 +121,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot inputs={ Array [
-
+
@@ -127,6 +131,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot
-
+
, ] } @@ -185,7 +191,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot inputs={ Array [
-
+
@@ -195,6 +201,7 @@ exports[`components/channel_notifications_modal/ExpandView should match snapshot
-
+
, ] } diff --git a/components/channel_notifications_modal/components/expand_view.jsx b/components/channel_notifications_modal/components/expand_view.jsx index 36683d2873bd..868c105b3e68 100644 --- a/components/channel_notifications_modal/components/expand_view.jsx +++ b/components/channel_notifications_modal/components/expand_view.jsx @@ -25,11 +25,12 @@ export default function ExpandView({ const inputs = [(
{(section === NotificationSections.DESKTOP || section === NotificationSections.PUSH) && -
+
-
+ } {section === NotificationSections.IGNORE_CHANNEL_MENTIONS && -
+
-
+ } {section === NotificationSections.MARK_UNREAD && -
+
-
+ }
)]; diff --git a/components/new_channel_modal/__snapshots__/new_channel_modal.test.jsx.snap b/components/new_channel_modal/__snapshots__/new_channel_modal.test.jsx.snap index f3cf130bfaa4..9fc7d28d3708 100644 --- a/components/new_channel_modal/__snapshots__/new_channel_modal.test.jsx.snap +++ b/components/new_channel_modal/__snapshots__/new_channel_modal.test.jsx.snap @@ -39,7 +39,6 @@ exports[`components/NewChannelModal should match snapshot, display only private