-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support isbits Union #2
Comments
Bump. FYI: Julia's PR 32448 is closed in Julia 1.4, which is now released. If I understand correctly it impacts you here. Despite NEWS saying it's a "language" feature, my understanding it's not, as in a syntax feature. It's however a implementation detail, impacting none who only use Julia (except for reinterpret), unless they use packages such as yours that do low-level stuff. I'm not sure what needs to be done here. Something and then limit to Julia 1.4+ (and drop REQUIRE). And before/until such a change, limit last release to supporting at most 1.3? |
Unions of isbits types are not directly isbits in Julia 0.7/1.0 so they need more specific support if we want to use them with Blobs.jl.
References:
I expect Blobs will need to do something like this:
Given that the optimization is specific to fields and that the tag is not part of the Union itself, I'm not quite sure if copying can be avoided though when the union is used?
The text was updated successfully, but these errors were encountered: