Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache new response iff successful #1305

Closed
Ajeyakrishna-k opened this issue Jul 19, 2023 · 0 comments · Fixed by #1322
Closed

Cache new response iff successful #1305

Ajeyakrishna-k opened this issue Jul 19, 2023 · 0 comments · Fixed by #1322
Assignees
@Ajeyakrishna-k

Comments

@Ajeyakrishna-k
Copy link
Contributor

Description of the issue:

  1. For CacheResponse Middleware: The request will timeout if there's any error on the api's where the cache middleware is used.
  2. For InvalidateCache Middleware: It will invalidate the cache without checking if the next actions are successful / unsuccessful.
@Ajeyakrishna-k Ajeyakrishna-k mentioned this issue Jul 19, 2023
Merged
@Ajeyakrishna-k Ajeyakrishna-k changed the title Issue: Cache & Invalidate response only if the action performed is successful Cache & Invalidate response only if the action performed is successful Jul 21, 2023
@ankushdharkar ankushdharkar changed the title Cache & Invalidate response only if the action performed is successful Cache new response iff successful Jul 21, 2023
@Ajeyakrishna-k Ajeyakrishna-k mentioned this issue Jul 24, 2023
Merged
@Ajeyakrishna-k Ajeyakrishna-k self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ajeyakrishna-k Ajeyakrishna-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache new response if successful Real-Dev-Squad/website-backend
1 participant
@Ajeyakrishna-k