Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip null check when creating main scheduler #595

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Skip null check when creating main scheduler #595

merged 1 commit into from
Nov 9, 2022

Conversation

JakeWharton
Copy link
Member

@JakeWharton JakeWharton commented Nov 9, 2022 •
edited

This is a tradeoff to allow replacing the main scheduler in tests without needing Robolectric.

Closes #594

@JakeWharton
Skip null check when creating main scheduler
44db927 
This is a tradeoff to allow replacing the main scheduler in tests without needing Robolectric.
@JakeWharton
Copy link
Member Author

Can I get a stamp from someone? @ZacSweers or @dlew maybe?

@JakeWharton JakeWharton merged commit 2100cf9 into 3.x Nov 9, 2022
@JakeWharton JakeWharton deleted the jw/fix-non-robolectric/2022-11-09 branch November 9, 2022 19:25
@JakeWharton
Copy link
Member Author

thanks!

@JakeWharton
Copy link
Member Author

Forgot to add the test I painstakingly wrote! #596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RxAndroid 3.0.1 NPE in JVM unit tests
2 participants
@JakeWharton @ZacSweers