fix: only switch chain when in focus #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbouder/rarity/963BLW5KcpfVHzscNnqDQE3T8xwP |
TBouder
reviewed
Sep 13, 2021
| @@ -0,0 +1,28 @@ | |||
| /****************************************************************************** | |||
| ** @Author: Rarity Extended | |||
| ** @Twitter: @MajorTom_eth | |||
There was a problem hiding this comment.
You may want to change that if you want :)
saltyfacu
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current auto chain switch logic, it is disruptive when users have multiple dapps open across different chains. Add a hook to check whether window is in focus and only prompt to chain network when it is in focus.
Also, fix a bug where
supportedChainIdswas set to a narrow set. This made the page swallow error when connecting wallet from an unknown network. Now that we have chain switch code, we can accept any network and prompt user to switch after wallet is injected.To reproduce this error, start the dapp with an unsupported network, e.g. polygon, and users do not get prompt to change network.