Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xt/check-signatures.t doesn't understand class $.variables #4471

Open
coke opened this issue May 23, 2024 · 1 comment
Open

xt/check-signatures.t doesn't understand class $.variables #4471

coke opened this issue May 23, 2024 · 1 comment
Labels
help wanted We need some help here xt Regarding current or new xt/ tests or the utils/

Comments

@coke
Copy link
Collaborator

coke commented May 23, 2024

Given

my role X::Proc::Async is Exception {
    has Proc::Async $.proc;
}

in the source, and this in the docs:

=head2 method proc

    method proc(X::Proc::Async:D --> Proc::Async)

this fails:

➜  doc git:(main) ✗ RAKUDO_SRC=/Users/coke/sandbox/rakudo xt/check-signatures.rakutest doc/Type/X/Proc/Async.rakudoc
1..1
# Subtest: check X::Proc::Async methods
    1..1
    ok 1 - # SKIP X::Proc::Async.proc not found on X::Proc::Async
ok 1 - check X::Proc::Async methods

(OK, it SKIPs, but it should pass cleanly) - it doesn't realize that a getter is created for that class

@coke coke added the docs Documentation issue (primary issue type) label May 23, 2024
@coke coke added this to the 2024-Quarter-2 milestone May 23, 2024
@coke coke added xt Regarding current or new xt/ tests or the utils/ help wanted We need some help here and removed docs Documentation issue (primary issue type) labels May 23, 2024
@coke coke modified the milestones: 2024-Quarter-2, 2024-Quarter-3 Jun 19, 2024
@coke
Copy link
Collaborator Author

coke commented Aug 2, 2024

Note - this is shown as a method in the source, but it's not a method. Perhaps the fix is to document it like https://docs.raku.org/type/IO/Handle#method_chomp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need some help here xt Regarding current or new xt/ tests or the utils/
Projects
None yet
Development

No branches or pull requests

1 participant