Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the examples on the root ReadMe with latest implementations and examples #73

Closed
SimonDarksideJ opened this issue May 3, 2024 · 2 comments · Fixed by #75
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@SimonDarksideJ
Copy link
Collaborator

SimonDarksideJ commented May 3, 2024

With all the recent changes, the main ReadMe has not been kept up to date, as such, none of the examples provided are functional and require additional parameters.

@SimonDarksideJ SimonDarksideJ added the bug Something isn't working label May 3, 2024
@StephenHodgson StephenHodgson added documentation Improvements or additions to documentation and removed bug Something isn't working labels May 3, 2024
@StephenHodgson
Copy link
Member

StephenHodgson commented May 4, 2024

Nothing has really changed much since your large refactor in #65/#66.
If you'd like to open a PR to update the docs with the refactor changes you made there, you are more than welcome.

I've only updated logging string outputs and fixes a few concurrency bugs.
I did update Rest.DownloadAudioClipAsync but only added optional stream and compression parameters.

@SimonDarksideJ
Copy link
Collaborator Author

SimonDarksideJ commented May 4, 2024

Essentially, although a single "RestParameters" example has been added, the other examples do not make it clear it is optional or required, additionally, some requests like AssetBundles are malformed.

But I will do a PR to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants