Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timer]add all soft timer config #9048

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

zmshahaha
Copy link
Contributor

@zmshahaha zmshahaha commented Jun 7, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加选项,开启该选项所有timer均在线程环境执行

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha marked this pull request as draft June 7, 2024 04:44
@zmshahaha zmshahaha marked this pull request as ready for review June 7, 2024 08:41
@zmshahaha zmshahaha marked this pull request as draft June 7, 2024 09:24
@zmshahaha zmshahaha marked this pull request as ready for review June 7, 2024 10:01
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多加测试用例,把timer相关corner case都尽可能覆盖

src/timer.c Show resolved Hide resolved
Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把 utest 加到 CI 里面

@zmshahaha
Copy link
Contributor Author

zmshahaha commented Jun 13, 2024

可以把 utest 加到 CI 里面

https://github.com/RT-Thread/rt-thread/actions/runs/9493849409/job/26163220310?pr=9048 里面jobs的kernel/timer就是吧

image

src/Kconfig Show resolved Hide resolved
@BernardXiong BernardXiong merged commit 59193df into RT-Thread:master Jun 19, 2024
47 checks passed
@zmshahaha zmshahaha deleted the timer branch June 24, 2024 08:40
messigogogo pushed a commit to messigogogo/rt-thread that referenced this pull request Jul 22, 2024
* add all soft timer

* update wq

* add timer test

* shield LOG_D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants