Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: rocBLAS failure during stream capture #1432

Merged
merged 1 commit into from
May 15, 2024

Conversation

rkamd
Copy link
Contributor

@rkamd rkamd commented May 14, 2024

resolves #SWDEV-454629

Summary of proposed changes:
Fix error during graph capture. A recent change in HIP runtime to not support hipStreamQuery() during stream capture ( matches CUDA behavior) causes rocblas_set_stream() to return error 'hipErrorStreamCaptureUnsupported' during stream capture.

  • This PR checks if the current stream is in capture mode, and skips the use of hipStreamQuery().
  • Fixed return of hipStreamQuery()

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkamd rkamd merged commit eec584f into release-staging/rocm-rel-6.2 May 15, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants