Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies for static compilation #1427

Conversation

arvindcheru
Copy link
Contributor

resolves #___

Summary of proposed changes:

  • Corrects the names for dependencies of statically compiled packages

Copy link
Contributor

@lawruble13 lawruble13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for library owner review prior to merging.

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, any requirement on rocm-cmake version or can this be cherry picked back into release-staging/rocm-rel-6.2 ?

@lawruble13
Copy link
Contributor

For this change in particular, there's no new rocm-cmake version requirement, although the names of the generated packages will be wrong there until the rocm-cmake changes for static packaging land back in mainline.

@arvindcheru arvindcheru merged commit cbe9b29 into ROCm:topic/init-static-libs-support May 8, 2024
1 check passed
TorreZuk added a commit that referenced this pull request May 10, 2024
Update package dependencies for static compilation (#1427)
ROCmMathLibrariesBot pushed a commit that referenced this pull request May 30, 2024
ROCmMathLibrariesBot pushed a commit that referenced this pull request Jun 28, 2024
* release-staging branch for ROCm 6.2
* Update package dependencies for static compilation (#1427)
* update CHANGELOG.md for ROCm 6.2

---------

Co-authored-by: Andrew Chapman <[email protected]>
Co-authored-by: arvindcheru <[email protected]>
Co-authored-by: Daine McNiven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants