Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working properly on gfx906 #93

Open
chenyongqing270 opened this issue Apr 29, 2021 · 2 comments
Open

Not working properly on gfx906 #93

chenyongqing270 opened this issue Apr 29, 2021 · 2 comments

Comments

@chenyongqing270
Copy link

There are three problems:
1、In the generated code, there is no instruction to output the result
2、without the the first problem solved ,the verification is still successful。
the problem can solve with the method that code snippet in FWD in conv_driver.cpp, should be add hipMemset call for device_output。
3、After I solved the first problem with the following method:
image
The result is not correct。both offset of output and Calculation results are incorrect。when i init all input value to 0.3 and weight value to 0.2, i get result as following:
image

@carlushuang
Copy link
Collaborator

carlushuang commented May 5, 2021

1、In the generated code, there is no instruction to output the result
what do you mean by output the result? Is it print the result of the output buffer? Currently this can be done by set env var PER_PIXEL_CHECK to 1

question 2/3 seems when you manually add the gfx906 code and have not got the correct result. Currently we are actively working on gfx908 codegen and not have enough time to fix some gfx906 code, due to limited resource. We will have that done when current task is done

@chenyongqing270
Copy link
Author

1、In the generated code, there is no instruction to output the result
what do you mean by output the result? Is it print the result of the output buffer? Currently this can be done by set env var PER_PIXEL_CHECK to 1

thanks for your reply。 i mean that there is no instruction to write the summation from v-register to global memory。
Because I have only one gfx906-card on hand,I have to do some research based on 906。Excuse me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants