-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hipLaunchKernelGGL can launch kernel multiple times #542
Comments
Thank you for reporting this (and for providing a repro); orthogonally to this issue, the current code has a logical issue (my fault) in that it'd needlessly iterate through the vector even after having found a valid kernel. |
#575 has been merged. Closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hipLaunchKernelGGL can launch the same kernel multiple times. Example: multiple_kernel_runs.zip
When the situation occurs:
bar
withbar::bar_impl()
function that launches a kernel.bar::bar_impl
is used in another header libraryfoo
to implementFooClass::foo()
.foobar
withfoobar()
func which callsFooClass::foo()
function.foobar()
and directlyFooClass::foo()
. Only one call to those functions launches the kernel. In that call instead of one launch, kernel is run twice.We suspect that probably in here should be a break after
hipModuleLaunchKernel()
.See ROCm/rocPRIM#13
The text was updated successfully, but these errors were encountered: